Skip to:
Content

BuddyPress.org

Opened 9 months ago

Closed 3 months ago

#8023 closed defect (bug) (fixed)

Style issue with Twenty Nineteen theme

Reported by: 1naveengiri Owned by: imath
Milestone: 5.0.0 Priority: normal
Severity: normal Version: 4.0.0
Component: Templates Keywords: has-patch has-screenshots needs-testing
Cc:

Description

There is some style issue i have noticed for dropdowns on Twenty Nineteen.
SInce Twenty Nineteen in default theme of WordPress so I think we should consider this as a issue.

Attachments (6)

Screenshot 2018-12-07 at 10.32.25 AM.png (266.1 KB) - added by 1naveengiri 9 months ago.
Screenshot 2018-12-07 at 10.33.12 AM.png (183.1 KB) - added by 1naveengiri 9 months ago.
Screenshot 2018-12-07 at 10.33.38 AM.png (173.7 KB) - added by 1naveengiri 9 months ago.
8023.patch (556 bytes) - added by imath 7 months ago.
8023.1.patch (9.4 KB) - added by imath 4 months ago.
8023.2.patch (27.3 KB) - added by imath 3 months ago.

Download all attachments as: .zip

Change History (16)

#1 @boonebgorges
9 months ago

  • Component changed from Core to Templates
  • Milestone changed from Awaiting Review to 5.0.0
  • Version changed from 4.1.0 to 4.0.0

Thanks for the report! Let's aim to get a twentynineteen stylesheet for 5.0.

#2 @wbcomdesigns
9 months ago

Adding all at the same place :)

1) Avatar Position inside Single activity has a large gap
http://prntscr.com/lt64c6

2) Button sizes at single member header are different
http://prntscr.com/lt65f3

3) Create Group Tab for mobile layout
http://prntscr.com/lt66u9

4) Create Group Tabs for ipad
http://prntscr.com/lt67lm

5) Responsive issue with Loop layout for column 2, 3 and 4 with Mac Air and Ipad
https://prnt.sc/lt2jog
https://prnt.sc/lt2ktj
https://prnt.sc/lt2lvg
https://prnt.sc/lt2mv1
https://prnt.sc/lt2n6j

6) Member single Multi Fields Multi select box style
https://prnt.sc/lt2t0h

7) Bulk Action style for messages
https://prnt.sc/lt2uf8

8) Members message - user-messages-bulk-actions style
https://prnt.sc/lt2vjm

9) Avatar shrinkage -
https://prnt.sc/lt2x4t

Last edited 9 months ago by wbcomdesigns (previous) (diff)

#3 @imath
8 months ago

@boonebgorges What about aiming to use BuddyPress blocks inside BuddyPress pages ?

I'm asking because now wide and full alignment can be added to blocks, we should probably explore how to use Blocks to inject BuddyPress content for the directory pages. For TwentyNineteen I bet a lot of display troubles could be fixed choosing wide or full.

This would probably mean to have the BP Rest API in though as the Block Editor requires the REST API :)

#4 @boonebgorges
7 months ago

Hi @imath - I'm definitely not opposed to exploring Block integration for BP content. But it's likely to be enormously complex. Even just introducing a single "BP" block that contains all of our content will mean reckoning with bp-pages and our routing system - we use bp-pages to determine the page we're on, but then we use theme compat to override the post content. I think that some high-level conceptualization and strategy would have to take place about how to adopt to the world of Blocks in a way that has a meaningful impact on BP sites.

In the meantime, I don't want the complexity of Block integration to get in the way of easier wins. We don't need to be Block-friendly to fix ol list-style-type for example :-D

#5 @imath
7 months ago

I see what you mean, but you’re more ambitious than I was 😅 I totally agree it would be very complex. I was more thinking of using a single block into the editor like a placeholder or a preview of the directory and use the block attributes to set the directory content alignment eg: full width or wide or regular.

@imath
7 months ago

#6 @imath
7 months ago

  • Keywords has-patch added; needs-patch removed

One possible quick fix is to use a check for the new wide-align Theme support to eventually include the alignwide class into our main container classes.

That's what I'm suggesting in 8023.patch

#7 @imath
4 months ago

  • Keywords good-first-bug added

#8 @imath
4 months ago

  • Keywords has-screenshots added; good-first-bug removed

So unlike what I thought first it's not a question of content width :)

I've started working on improving the Twenty Nineteen compatibility from this personal branch of BuddyPress because there's a lot of CSS adaptation to make.

8023.1.patch is a first step to mainly improve the Activity directory. Some improvements spread to other directories like the dropdown filters which are the first style issue reported by @1naveengiri in this ticket.

I'll cary on working on the 9 points reported by @wbcomdesigns

Feel free to test the patch ;)

@imath
4 months ago

#9 @imath
3 months ago

  • Keywords needs-testing added

8023.2.patch improves .1.patch by fixing the remaining 9 points (except for point 5). It would be great to have some of you to test this patch ;)

@imath
3 months ago

#10 @imath
3 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12398:

BP Nouveau: polish the layout of BuddyPress parts in Twenty Nineteen

Fixes #8023

Note: See TracTickets for help on using tickets.