Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#7944 closed defect (bug) (fixed)

Empty members search bug with nouveau template

Reported by: casper99's profile casper99 Owned by: imath's profile imath
Milestone: 3.2.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch commit
Cc:

Description

"BuddyPress Nouveau" shows empty results (no members), while Legacy lists members for the same query.

Tested with fields generated by BP Default Data plugin, they contain space, which in URL results in a plus + sign. Also the "search-box" still shows plus signs between the words.

Also reported on (with possible solution):
​https://github.com/buddypress/next-template-packs/issues/105

Attachments (1)

7944.patch​ (547 bytes) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @imath
6 years ago

  • Keywords reporter-feedback added

@casper99

I've just tested, using the BP Default Data plugin. And when I search for "Thomas Carew", here is what I Get :

https://cldup.com/Jl-zDRBTdC.png

So to me it seems to work fine in BP Nouveau. Do you have an example of problematic user/profile data ?

#2 @casper99
6 years ago

@imath: Thanks for your efforts.

https://image.ibb.co/icAfJ9/buddypress_problem.jpg

also problem with encoding (German umlaut)...

https://image.ibb.co/m752WU/buddypress_encoding_problem.jpg

Last edited 6 years ago by casper99 (previous) (diff)

#3 @casper99
6 years ago

  • Keywords reporter-feedback removed

@imath
6 years ago

#4 @imath
6 years ago

  • Keywords has-patch reporter-feedback added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.2.0

Thanks @casper99 for your screenshots. I confirm there is an issue when a link is clicked from the user's profile screen.

​7944.patch is fixing the issue for me :

Link with data containing a space :
https://cldup.com/wQLXzcT1pm.png

Link with special chars :
https://cldup.com/ioTye3hu3b.png

I think we should fix in 3.2. @casper99 could you apply and test the patch to check it's working for you too ?

#5 @casper99
6 years ago

  • Keywords reporter-feedback removed

@imath : Thank you very much for your work!
The patch works for me, but "buddypress-nouveau.min.js" also needs to be updated.

Best regards

#6 @imath
6 years ago

  • Keywords commit added

Thanks a lot for your feedback.

I'll commit the patch soon. Don't worry for the minified version of the JavaScript : it is built during the packaging of the release.

#7 @imath
6 years ago

In 12200:

BP Nouveau: URI decode search terms before doing AJAX requests

When a search request is triggered using a BuddyPress component URL search query var (eg: clicking on a profile data link), we need to URI decode the search terms to make sure search results are consistent.

Props casper99

See #7944 (branch 3.0)

#8 @imath
6 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12201:

BP Nouveau: URI decode search terms before doing AJAX requests

When a search request is triggered using a BuddyPress component URL search query var (eg: clicking on a profile data link), we need to URI decode the search terms to make sure search results are consistent.

Props casper99

Fixes #7944 (Trunk)

Note: See TracTickets for help on using tickets.