Skip to:
Content

BuddyPress.org

#7828 closed enhancement (fixed)

BP Nouveau: Improve responsive views of widgets: Group, Member, Friends, & Recent Networkwide Posts

Reported by: mercime Owned by: djpaul
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch has-screenshots
Cc:

Description

Attaching screenshots and patch.

Attachments (7)

widget-responsive-320.png (61.0 KB) - added by mercime 17 months ago.
widget-members-b4-aft.png (151.3 KB) - added by mercime 17 months ago.
widget-recent-network-posts.png (174.2 KB) - added by mercime 17 months ago.
7828.patch (18.7 KB) - added by mercime 17 months ago.
7728.gif (2.5 MB) - added by mercime 17 months ago.
Shows the before styling of the Members widget on the Group main content widget area
7728-after.gif (3.0 MB) - added by mercime 17 months ago.
Shows the after responsive views of the Members widget on the Group main content widget area
another-widget.png (361.4 KB) - added by mercime 17 months ago.

Change History (18)

@mercime
17 months ago

#1 @mercime
17 months ago

widget-members-b4-aft.png and widget-recent-network-posts.png show the before and after for the following from left to right:

  • Twenty Fourteen primary sidebar
  • Twenty Fourteen content sidebar
  • Twenty Fifteen primary sidebar
  • Twenty Sixteen primary sidebar
  • Twenty Seventeen footer sidebars

7828.patch makes the BP widgets show up with consistent layouts across different themes and responsive views. This involved simplifying styles to the minimum and changing specificity of selectors used previously.

Changed the specificity of the following:

  • sidebar widgets: lessened specificity from .widget-area .buddypress.widget to .buddypress.widget to cover the basic widget style and to ensure the style gets applied even to sidebars without the .widget-area class which the default themes have.
  • main content widget areas (user and group widgets): Increased specificity from .buddypress.widget to buddypress-wrap .buddypress.widget

@mercime
17 months ago

Shows the before styling of the Members widget on the Group main content widget area

@mercime
17 months ago

Shows the after responsive views of the Members widget on the Group main content widget area

#2 @mercime
17 months ago

@hnla when you have the time, please check the changes made to the widget styles. Thanks.

#3 @mercime
17 months ago

  • Keywords has-patch has-screenshots added

#4 @DJPaul
17 months ago

  • Milestone changed from Awaiting Review to 3.1

#5 @hnla
17 months ago

@mercime cool looks ok, will run patch when I have a minute... sadly the widgets didn't get the attention they needed, bit of a pita these widgets :)

#6 @mercime
17 months ago

@DJPaul @hnla Please reconsider and move this ticket to 3.0 so I/anyone can commit it. Otherwise, it feels like someone letting a friend go to a party with salad stuck between his teeth :(

Last edited 17 months ago by mercime (previous) (diff)

#7 follow-up: @hnla
17 months ago

The grid boxes need some margining to keep them from closing up/abutting in the narrow view, the issue above is partly due to avatars needing to be of a larger size, on any sane setup the default avatar uploads should be of a much larger size to allow for better rendering.

I'm happy to slip this in but I'm not scrum master, product owner, not my call to make :(

#8 in reply to: ↑ 7 @mercime
17 months ago

Replying to hnla:

The grid boxes need some margining to keep them from closing up/abutting in the narrow view, the issue above is partly due to avatars needing to be of a larger size, on any sane setup the default avatar uploads should be of a much larger size to allow for better rendering.

Thanks for your feedback @hnla. 10-4 on larger avatar size can be implemented by developers or site builders otherwise the default 50px x 50px image is stretched to unlimited 'pixelation-ness'.

I'm happy to slip this in but I'm not scrum master, product owner, not my call to make :(

Will look for a wishing star tonight.

#9 @hnla
17 months ago

I thought we had changed the avatar default sizes, cos we had the opportunity to with Nouveau.

#10 @DJPaul
17 months ago

  • Milestone changed from 3.1 to 4.0

Milestone renamed

#11 @djpaul
16 months ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 12171:

Templates, Nouveau: fix widget responsiveness.

Fixes #7828

Props mercime

Note: See TracTickets for help on using tickets.