Skip to:
Content

BuddyPress.org

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#7804 closed defect (bug) (fixed)

Nouveau: Border color for count on a selected nav is too light

Reported by: r-a-y Owned by: r-a-y
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

See attached screenshot:
https://i.imgur.com/q6wrRad.png

In the image, "Notifications" is selected, but the count looks like it is white-on-white.

Here's what it looks like after the attached patch:
https://i.imgur.com/CWHsRnG.png

Side note: I think we might need to audit our colo(u)rs for contrast accessibility. I'm noticing a lot of light-gray that is hard to view.

Attachments (1)

7804.01.patch (1.9 KB) - added by r-a-y 14 months ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
14 months ago

#1 @DJPaul
14 months ago

Sure, better is better for now.

#2 @hnla
14 months ago

Side note: I think we might need to audit our colo(u)rs for contrast accessibility

@mercime did do a significant amount of contrast checking a while back to ensure light greys fell within contrast params.

#3 @r-a-y
14 months ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 12068:

Nouveau: Make border color darker for the selected nav item count.

Fixes #7804.

#4 @mercime
14 months ago

@hugo @r-a-y Contrast checking for WCAG 2.0 AA compliance only involves the colors of text and background combination. Done.

There are failing link color issues coming from themes which I addressed in #7222 for BP Legacy for the respective default Twenty-* themes. Haven't done that in BP Nouveau because we have no stylesheets for respective themes, unless you want to hijack all themes' default link colors, whoa!

Note: See TracTickets for help on using tickets.