Skip to:
Content

BuddyPress.org

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#7803 closed defect (bug) (fixed)

Nouveau: Avatars are wrongly-sized in Twenty Twelve

Reported by: r-a-y Owned by: r-a-y
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: commit
Cc:

Description

See attached screenshot:
https://i.imgur.com/rehWrCV.png

Attached patch fixes this.

Attachments (1)

7803.01.patch (1.4 KB) - added by r-a-y 16 months ago.

Download all attachments as: .zip

Change History (8)

@r-a-y
16 months ago

#1 @r-a-y
16 months ago

Disregard the "tabbed-links" change in the patch. grunt rtlcss caught that.

#2 @DJPaul
16 months ago

Looks fine!

#3 @r-a-y
16 months ago

@hnla - Can you sign off on this? Just want to make sure you're aware of the problem and if the solution is good enough.

#4 @hnla
16 months ago

@r-a-y It looked good, running patch to check in more detail.

#5 @hnla
16 months ago

  • Keywords commit added; has-patch removed

@r-a-y The proposed fix is good, isolated to the act stream avatar should be safe. It did make me wonder though why I didn't add a global rule & thought I had e.g #buddypress .avatar {height: auto; max-width: 100%} which would trap any issues like this. Better is we don't specify the image width/height atts which causes the issue when height auto isn't explicitly set to override.

Lets commit this patch, it corrects issue for smallest cost, thanks for spotting.

#6 @r-a-y
16 months ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 12069:

Nouveau: Fix avatar sizing in the activity stream for certain themes.

Props r-a-y, hnla.

Fixes #7803.

#7 @r-a-y
16 months ago

Thanks for verifying, @hnla!

Note: See TracTickets for help on using tickets.