Skip to:
Content

BuddyPress.org

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#7771 closed defect (bug) (fixed)

[BP Nouveau] Updated Feedback messages are hidden in TwentySeventeen

Reported by: imath Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch 2nd-opinion
Cc:

Description

If you try to post an activity while the scope is not consistent with it (eg: you are on the Activity Directory the Mentions scope is activated), Nouveau is throwing a feedback message instead of prepending the Activity update into a wrong stream. This feedback message contains a link to the activity single view as shown on the screencap below.

https://cldup.com/9F8fiktFI3.png

TwentySeventeen is using a css rule to hide the .updated class when not .published at the same time. This could probably be fixed using a css rule to override it.

Or we can improve the Feedback view so that it's possible to pass it some additionnal classes just like I'm suggesting into the attached patch.

Attachments (1)

7771.patch (1.4 KB) - added by imath 19 months ago.

Download all attachments as: .zip

Change History (5)

@imath
19 months ago

#1 @hnla
19 months ago

If this is simply adding some classes lets add them then - commit the patch, but does this then require adjusting Styles, if so can ( I've not had chance to look at the actual issue ) can we note that on another ticket and reference this one, and I'll try and deal with?

#2 @hnla
19 months ago

@imath looking at this I'm struggling to understand what the expected behaviour is?

In normall context view i.e 'all' tab posting update simply inserts and closes the post form box.

In mentions view we see the link you show above.
What I don't get is what is being hidden, what is twentyseventeen doing?

bty & fyi have updated the styling of that message link as the class .updated wasn't in the grouped message rulesets so it now styles with success icon and coloured background.

#3 @imath
19 months ago

  • Resolution set to fixed
  • Status changed from new to closed

@hnla well actually you already fixed it here r12011 :)

I was suggesting to use another variable to do what you hardcoded into src/bp-templates/bp-nouveau/js/buddypress-activity-post-form.js . But it's fine the way you did it. Closing this ticket. Thanks a lot for your help and sorry for the confusion :)

#4 @hnla
19 months ago

Well I prefer dynamic vars over hardcoded but in this instance I think we're safe with those hardcoded classes as they don't need to change as they're a sort of general global class for messages elements.

Note: See TracTickets for help on using tickets.