Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#7772 closed defect (bug) (fixed)

BP Nouveau: remove all code relative to activity timestamp updates in favor of Moment.js and Livestamp.js

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit
Cc:

Description

There's still some "old" code about dynamically updating the activity entries timestamps in BP Nouveau. Since 2.7.0 Moment.js and Livestamp have been introduced to perform these dynamic timestamp updates for BP Legacy.

I think we should get rid of the "old" code and let Moment.js and Livestamp.js take care of dynamically updating the activity entries timestamps for BP Nouveau.

See attached patch.

Attachments (1)

7772.patch​ (7.9 KB) - added by imath 7 years ago.

Download all attachments as: .zip

Change History (4)

@imath
7 years ago

#1 @DJPaul
7 years ago

  • Keywords commit added

Thanks :)

#2 @imath
7 years ago

  • Owner set to imath
  • Status changed from new to assigned

#3 @imath
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12002:

BP Nouveau: use Moment.js & Livestamp.js to update activity timestamps

Before these two JavaScript libraries were introduced in BuddyPress Core (2.7.0), i added some custom JavaScript code to perform the dynamic activity timestamp update task. Now these two libraries are available and do the job way better, it is about time to say goodbye to this code.

Fixes #7772

Note: See TracTickets for help on using tickets.