Deprecated functions for v3.0

[r-a-y]

While working on #7218, I encountered some older functions that are not really used in the Members component anymore:

bp_core_action_set_spammer_status() - ​https://buddypress.trac.wordpress.org/browser/tags/2.9.3/src/bp-members/bp-members-actions.php#L17
bp_core_action_delete_user() - ​https://buddypress.trac.wordpress.org/browser/tags/2.9.3/src/bp-members/bp-members-actions.php#L74

According to the inline doc, we unhooked these functions in BP 1.6 and the Settings component pages took precedence. Time to deprecate?

Also would be good to check if we can remove some other functions as well.

[DJPaul]

Sure.

It’s a shame BP is loading the deprecated code files all the time - you might remember I tried to adjust that to load only for old sites a few releases back, but that implementation was wrong and we had to end up reverting the implementation. So moving the functions now won’t have any impact today but will hopefully in the future. 😁

[djpaul]

In 11940:

Core: deprecate functions soft-removed in BP 2.6

Fixes #7738

Props r-a-y

[djpaul]

In 11941:

Core: fix missing deprecation notice for certain functions.

See #7738