Skip to:
Content

BuddyPress.org

Opened 18 months ago

Closed 17 months ago

Last modified 3 months ago

#7739 closed defect (bug) (fixed)

BP Nouveau: at-mentions does not work in Activity Reply

Reported by: mercime Owned by: imath
Milestone: 3.0 Priority: low
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

While testing djpaul's patch for #7724, I found that at-mentions does not work for Activity Replies only when the Template Pack is set to BP Nouveau.

Attachments (1)

7739.patch (541 bytes) - added by imath 17 months ago.

Download all attachments as: .zip

Change History (6)

#1 @DJPaul
18 months ago

  • Milestone changed from Awaiting Review to 3.0
  • Priority changed from normal to low

@imath
17 months ago

#2 @imath
17 months ago

  • Keywords has-patch added

@mercime at-mentions are working for me. It's the at-suggestions that are not working right ?

Actually BP Legacy has the same issue :) You just don't see it right away. Try to change the activity filter (eg show: new members) then begin to type @someone and you'll see that suggestions are also not showing into BP Legacy.

The fact you see it right away in BP Nouveau is because it starts by an ajax request right away. But the attached patch is fixing it :)

#3 @mercime
17 months ago

7739.patch works great @imath on directory screens and activity permalink screen, thank you.

Actually BP Legacy has the same issue :) You just don't see it right away. Try to change the activity filter (eg show: new members) then begin to type @someone and you'll see that suggestions are also not showing into BP Legacy.

Good catch! Didn't think of changing the filters when I tested BP Legacy for #7724 :D

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


17 months ago

#5 @imath
17 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12042:

BP Nouveau: make sure BP Suggestions are aware of Ajax injected markup

Fixes #7739

Note: See TracTickets for help on using tickets.