Skip to:

Opened 6 years ago

Closed 6 years ago

#7724 closed defect (bug) (fixed)

at-mentions adds unexpected characters wrapped around username

Reported by: mercime's profile mercime Owned by: djpaul's profile djpaul
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Activity Keywords: has-screenshots has-patch

Description (last modified by mercime)

Tested so far on the Activity post form and the Messages > compose form: After selecting the username via mouse click or keyboard press Enter, the username shows up in input field with unexpected characters surrouding the username like so </>@matraca</>

Attaching gif of the issue.

P.S. Happens on bp-legacy and bp-nouveau

Attachments (2)

characters-at-mentions.gif (138.4 KB) - added by mercime 6 years ago.
7724.01.patch (545 bytes) - added by DJPaul 6 years ago.

Download all attachments as: .zip

Change History (10)

#1 @mercime
6 years ago

  • Keywords has-screenshots added

#2 @mercime
6 years ago

  • Description modified (diff)

6 years ago

#3 @DJPaul
6 years ago

  • Component changed from Core to Activity
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.0

For 3.0, we've updated the mentions javascript libraries. We've had to update the config file for various upstream changes, and I think this might be another one.

I've attached a patch which removes these which were added specifically for TinyMCE compatibility in the wp-admin post editor (try it!).

We need to spend a bit more time testing that the at-mentions still works everywhere with this change.

#4 @mercime
6 years ago

@djpaul Just tested the patch on MAMP

bp-nouveau: Patch works. Tested on Activity post form and Compose message form. New issue found on Activity reply form and Activity permalink reply where the at-who dropdown/container does not show up.

bp-legacy: Patch works on all forms mentioned above. No strange characters and the at-who container/dropdown shows up.

#5 @DJPaul
6 years ago

Did you test on a Wp-admin post or page edit screen text area/visual editor?

#6 @mercime
6 years ago

@djpaul Just tested it now in wp-admin edit screen Page and edit Post on Windows 10 insider build with Chrome and Firefox and Edge. The at-who container shows up and does not have strange characters on selection and save.

#7 @DJPaul
6 years ago

Great, thanks so much for so much browser testing on this @mercime!

#8 @djpaul
6 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11912:

Activity: fix mentions.js config for library updates in r11795

Fix </>@matraca</> showing up in text fields after a mention is added.

This used to be required for TinyMCE support, but apparently a change in the upstream library takes care of this.

Fixes #7724

Props mercime, djpaul

Note: See TracTickets for help on using tickets.