Skip to:

Opened 2 years ago

Closed 22 months ago

#7723 closed defect (bug) (fixed)

BP-Nouveau: Cannot Star or Unstar in single message view

Reported by: mercime Owned by: imath
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-screenshots has-patch commit


There's no way to do Star/Unstar using either mouse click, keyboard press, nor touch screen. Tooltip does not show up as well.

Attaching one animated gif showing the issue using mouse click, keyboard press, and touch screen not working on star.

Attachments (4)

star-unstar-single-message.gif (111.8 KB) - added by mercime 2 years ago.
7723.patch (3.9 KB) - added by imath 22 months ago.
7723-tooltips-etc.patch (6.7 KB) - added by mercime 22 months ago.
message-delete-star.png (14.1 KB) - added by mercime 22 months ago.

Download all attachments as: .zip

Change History (11)

#1 @mercime
2 years ago

  • Keywords has-screenshots added

#2 @DJPaul
2 years ago

  • Milestone changed from Awaiting Review to Awaiting Contributions

22 months ago

#3 @imath
22 months ago

  • Keywords has-patch reporter-feedback added
  • Milestone changed from Awaiting Contributions to 3.0

Hi !

7723.patch is a first attempt to improve feedbacks about starring/unstarring a message.

I also moved above the messages the feedback messages that were added at the bottom.

Is it better this way ?

This ticket was mentioned in Slack in #buddypress by imath. View the logs.

22 months ago

#5 @mercime
22 months ago

@imath. Patch works great. 7723-tooltips-etc.patch realigns the tooltips for the "Delete Conversation" and "Unstar Message" buttons as shown in image above as well as apply changes in original patch to sass file.

I also moved above the messages the feedback messages that were added at the bottom.
Is it better this way ?

+100 from me. Much easier for users to see the feedback on mobile and desktop.

Last edited 22 months ago by mercime (previous) (diff)

#6 @imath
22 months ago

  • Keywords commit added; reporter-feedback removed

@mercime Awesome ! thanks a lot for your feedback and for having updated the patch to include the sass thing 👌. I'll add it to the tonight's commit list ☺️

#7 @imath
22 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12041:

BP Nouveau: add interactivity to starring buttons in single Messages

  • Make sure the BP Tooltip is displayed
  • Toggle the color of the star when starring unstarring
  • Move the feedback messages over the threads

Props mercime

Fixes #7723

Note: See TracTickets for help on using tickets.