Skip to:
Content

BuddyPress.org

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#7691 closed defect (bug) (fixed)

At User's front Page Edit your bio link leads to current admin user backend profile

Reported by: vapvarun Owned by: hnla
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-screenshots
Cc:

Description

It should link to displayed user backend profile or we can simply hide it from the displayed user's front page.

https://screencast-o-matic.com/screenshots/u/f0ik/1518207358488-82448.png

Change History (4)

#1 @vapvarun
19 months ago

to replicate it, Please make sure you have enabled BP Nouveau

#2 @hnla
19 months ago

@vapvarun Thanks for moving the ticket over from github.

Looking at this further it seems there is an issue possibly with WP here as the link always seems to resolve to the WP current logged in user regardless of the ID that is passed to the WP get_edit_profile_url() function, in our case the bp_displayed_user_id() even passing a hardcoded int representing the correct displayed user results in resolving to the admin or bp_moderate user.

The simplest way to resolve this it to remove the check for bp_moderate in the default-front.php template, it's a convenience link that really isn't that useful or necessary, admins may navigate to the backend if they really need to edit a users profile.

So the link now will only appear if this is bp_is_my_profile()

I'm closing this ticket on that basis, however if you feel this is not the best resolution please re-open.

#3 @hnla
19 months ago

  • Owner set to hnla
  • Resolution set to fixed
  • Status changed from new to closed

In 11852:

Nouveau: Edit profile link, default-front.php

The link is intended to reference the displayed users WP profile, the link is allowed for admins(bp_moderate) users too, however the link always resolves to the current logged in user regardless of whether a hardcoded user id is set ( e.g bp_displayed_user_id() ) so admins will resolve to their personal WP profile not the displayed user.

This commit removes the admin link view, only showing link for bp_is_my_profile() The admin provision is simply a convenience and not overly important.

Props vapvarun

Fixes #7691

#4 @DJPaul
19 months ago

  • Component changed from Core to Templates
  • Milestone changed from Awaiting Review to 3.0
Note: See TracTickets for help on using tickets.