Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7692 closed defect (bug) (fixed)

Nouveau: Heartbeat new activity items

Reported by: hnla Owned by: djpaul
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch needs-testing
Cc:

Description

Heartbeat checks and notifies of new act items posted.
Clicking it's link should inject the new item into the main act stream ul list.

Currently this is broken and adds li markup outside the loop.

This is in part due to the changes effected to change the loops relevant classes & data attr to ensure the list are true lists and not displaying messages in r11825 ( see also #7688 ).

Relevant files:
buddypress-activity.js L:58>
groups/single/activity.php ( template ul & parent need classes & data attr swapping )

I have refactored locally to the nth degree and almost got there however cannot get the new activity to inject to the ul (prepend) any change I make to jquery elements selectors for the click events silently breaks Ajax & without errors generated.

Attachments (1)

7692.diff (753 bytes) - added by boonebgorges 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @DJPaul
4 years ago

  • Milestone changed from Awaiting Review to 3.0

@boonebgorges
4 years ago

#2 @boonebgorges
4 years ago

  • Keywords has-patch needs-testing added

If I'm understanding the problem correctly, 7692.diff should fix it.

#3 @DJPaul
4 years ago

Boom! Wonderful. Thanks so much for the patch, Boone!

#4 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11909:

Templates, Nouveau: fix Activity heartbeat JS inserting new items in wrong place.

Fixes #7692

Props boonebgorges

#5 @hnla
4 years ago

Thanks @boonebgorges , was making me cry that one was.

Last edited 4 years ago by hnla (previous) (diff)
Note: See TracTickets for help on using tickets.