Skip to:

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7579 closed defect (bug) (fixed)

Make tests pass on PHP 7.1

Reported by: thebrandonallen's profile thebrandonallen Owned by: djpaul's profile djpaul
Milestone: 3.0 Priority: normal
Severity: normal Version: 2.6.0
Component: Blogs Keywords: has-patch commit


#WP39277 was fixed in WP 4.7.3, which means PHP 7.1 no longer needs to be allowed to fail, per [11391].

Attached patch moves PHP 7.1 out of allowed failure status, and fixes a type-casting issue in the blogs component causing tests to fail.

Attachments (1)

7579.01.diff (1014 bytes) - added by thebrandonallen 7 years ago.

Download all attachments as: .zip

Change History (4)

#1 @r-a-y
7 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.0

Nice work, @thebrandonallen.

Should be committed once we start work on 3.0!

#2 @djpaul
7 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11660:

CI: tests must pass on PHP 7.1.

Fixes #7579

Props thebrandonallen

#3 @r-a-y
7 years ago

In 11668:

Blogs: Ensure offset in bp_blogs_record_existing_blogs() is integer-typecasted.

After r11660, fixes issues with multisite tests failing in PHP 7.1

Props thebrandonallen.

Fixes #7579.

Note: See TracTickets for help on using tickets.