Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#7544 closed enhancement (fixed)

Closing PHP tag in various bp-legacy templates

Reported by: lenasterg's profile lenasterg Owned by: djpaul's profile djpaul
Milestone: 2.9 Priority: lowest
Severity: trivial Version:
Component: Core Keywords: has-patch
Cc:

Description

Hi.
I noticed that various bp-legacy templates have PHP closing tags at the last line.

Bests,
Lena

Attachments (2)

remove_closing_php.patch​ (13.1 KB) - added by lenasterg 7 years ago.
7544.diff​ (23.3 KB) - added by milindmore22 7 years ago.
removed extra spaces from previous patch added proper patch

Download all attachments as: .zip

Change History (6)

@lenasterg
7 years ago

#1 @DJPaul
7 years ago

Hi @lenasterg

Good spot. A lot of the changed files now have a trailing space -- e.g. src/bp-templates/bp-legacy/buddypress/groups/create.php ends "do_action( 'bp_after_group_activity_content' ); "

Any chance you can update the patch and remove those spaces? Otherwise there's not a lot of point removing the closing tags if, by doing so, we introduce a new imperfection? Thanks.

@milindmore22
7 years ago

removed extra spaces from previous patch added proper patch

#2 @milindmore22
7 years ago

  • Keywords has-patch added

#3 @DJPaul
7 years ago

  • Milestone changed from Awaiting Review to 2.9

@milindmore22 Thanks!

#4 @djpaul
7 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 11591:

Templates, Legacy: remove trailing slashes from files.

Props @lenasterg, @milindmore22

Fixes #7544

Note: See TracTickets for help on using tickets.