Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7471 closed defect (bug) (fixed)

Twenty Seventeen dark - members listing - Order by drop down text hard to see

Reported by: dsided Owned by: mercime
Milestone: 2.9 Priority: normal
Severity: normal Version: 2.8.2
Component: Templates Keywords: has-patch
Cc:

Description

In the /members listing (members-loop) the drop down "Order by" are set white text on a light grey background. Background should be changed to 333

Attachments (4)

Members Twenty Seventeen dark drop down.PNG (15.7 KB) - added by dsided 3 years ago.
Screen shot of members listing - dark - drop down
7471.diff (576 bytes) - added by dsided 3 years ago.
7471.patch (557 bytes) - added by hnla 3 years ago.
Correct Chrome issue with inherited background on select element dropdown
7471-01.patch (582 bytes) - added by hnla 3 years ago.
Updated patch to revise & reduce the scss nesting level - avoid linting error.

Download all attachments as: .zip

Change History (9)

@dsided
3 years ago

Screen shot of members listing - dark - drop down

#1 @hnla
3 years ago

In which browser are we seeing this?

Answered my own question in Chrome FF is correctly inheriting color.

Last edited 3 years ago by hnla (previous) (diff)

#2 @dsided
3 years ago

  • Keywords has-patch added

I've added the following css to target the drop down options background to a dark grey:

body.colors-dark #page #buddypress #members-order-by option {
	background-color: #333;
}

Please see 7471.diff attached.

@dsided
3 years ago

@hnla
3 years ago

Correct Chrome issue with inherited background on select element dropdown

#3 @hnla
3 years ago

@dsided yep problem is with Chrome it seems, FF is fine, revised the patch to effect a explicit color on the option element for both in the scss sheet, many thanks.

I'll commit this a little later when I have a moment.

@hnla
3 years ago

Updated patch to revise & reduce the scss nesting level - avoid linting error.

#4 @mercime
3 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11515:

Improve visibililty of selectbox options for the Twenty Seventeen dark theme.

Props dsided, hnla.
Fixes #7471.

#5 @mercime
3 years ago

  • Milestone changed from Awaiting Review to 2.9
Note: See TracTickets for help on using tickets.