Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7310 closed defect (bug) (fixed)

Admin Bar: double arrows with WP 4.7 trunk

Reported by: Offereins Owned by: mercime
Milestone: 2.7.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: dev-feedback has-patch
Cc: lmoffereins@…

Description

Using WP 4.7 trunk BP's admin bar menu displays arrows on both sides of the admin bar profile menu items. Haven't looked what the issue could be.

See the image posted in #buddypress Slack.

Attachments (2)

pasted_image_at_2016_10_28_11_25_am.png (39.2 KB) - added by slaFFik 3 years ago.
7310.patch (1.1 KB) - added by mercime 3 years ago.

Download all attachments as: .zip

Change History (11)

#1 @hnla
3 years ago

I see those too. Are you running twentyseventeen?

Not sure where the issue lies but they borked my bloody work with templates in Nouveau, looks like they may have removed the arrangement they had for two column switching of 'page' layouts while introducing something they should never have added an open ended text area to add CSS, I made a comment on core-theme about that as did others but it still goes in!

#2 @slaFFik
3 years ago

  • Keywords dev-feedback added

In my opinion this should be fixed before 4.7 release, so basically in BuddyPress 2.7.1 or 2.7.2 (if we go that far with 2.7 branch).

Would be nice to get milestone feedback from core devs, and @mercime

#3 @mercime
3 years ago

The arrows are welcome on small screens but not in screen widths larger than 600px. One way to fix these new right arrows from showing up in large screens is by adding the following styles in admin-bar.css:

#wpadminbar .wp-admin-bar-arrow-right {
	display: none;
}

@media screen and (max-width: 600px) {
	#wpadminbar .wp-admin-bar-arrow-right {
	     display: block;
	}
}

This works in IE 11 below as well as in modern browsers.

Last edited 3 years ago by mercime (previous) (diff)

@mercime
3 years ago

#4 @mercime
3 years ago

  • Keywords has-patch added

#5 @hnla
3 years ago

More importantly why are these appearing what was the intended purpose of them ( look to be a rtl affectation to me on, but haven't delved deeper into this).

I'm not sure we should add styles to fix something that is either intended for a reason or that is a error which needs to be corrected at some other level.

Can we have an explanation of what these are before we add any supposed 'fixes'?

#6 @hnla
3 years ago

Ok ignore the above I see the point of them now commit the fix @mercime, one question is this copying WP's use of max-width media query, as the alternative and perhaps more usual query approach is min-widths so hiding the arrows down to.

#7 @mercime
3 years ago

  • Milestone changed from Awaiting Review to 2.7.1

In my opinion this should be fixed before 4.7 release, so basically in BuddyPress 2.7.1 ...

Thanks @slaFFik :) Doing this for 2.7.1.

one question is this copying WP's use of max-width media query, as the alternative and perhaps more usual query approach is min-widths so hiding the arrows down to.

Thanks @hnla. Understood, mobile-first approach would be better. Thing is, we're still supporting IE 8/9 on the back end.

#8 @mercime
3 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11215:

Remove additional arrows from appearing on the BuddyPress' my_account_menu.

The new arrow icons introduced in WP 4.7 trunk caused additional arrows to show
up on the right side of the toolbar menu links for BuddyPress logged in users
which already had arrow icons on the left side for large screens.

Props Offereins, hnla, slaFFik, mercime.
Fixes #7310 (trunk).

#9 @mercime
3 years ago

In 11216:

Remove additional arrows from appearing on the BuddyPress' my_account_menu.

The new arrow icons introduced in WP 4.7 trunk caused additional arrows to show
up on the right side of the Toolbar menu links for BuddyPress logged in users
which already had arrow icons on the left side for large screens.

Props Offereins, hnla, slaFFik, mercime.
Fixes #7310 (2.7 branch).

Note: See TracTickets for help on using tickets.