Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#7267 closed enhancement (fixed)

Welcome Screen for BP 2.7.0

Reported by: mercime Owned by: mercime
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch has-screenshots
Cc:

Attachments (11)

BP-2-7-welcom.png (214.3 KB) - added by mercime 3 years ago.
First pass
7267.patch (29.0 KB) - added by mercime 3 years ago.
7267.2.patch (29.0 KB) - added by mercime 3 years ago.
BP-2-7-welcome-final.png (76.5 KB) - added by mercime 3 years ago.
final version as of BP RC1
7267.typos.patch (5.3 KB) - added by slaFFik 3 years ago.
Hopefully the last one, front/back([-| ])end
7267-3.patch (9.3 KB) - added by mercime 3 years ago.
BP-2-7-welcome-3.png (245.3 KB) - added by mercime 3 years ago.
7267.4.patch (10.3 KB) - added by dcavins 3 years ago.
Text changes
7267.4.2.patch (11.5 KB) - added by mercime 3 years ago.
BP-2-7-welcome-5.png (245.7 KB) - added by mercime 3 years ago.
BP-2-7-welcome-finally.png (247.8 KB) - added by mercime 3 years ago.

Download all attachments as: .zip

Change History (50)

#1 @mercime
3 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


3 years ago

@mercime
3 years ago

First pass

@mercime
3 years ago

#4 @mercime
3 years ago

  • Keywords has-patch has-screenshots added

First pass. Something a bit different yet familiar for the Developer and Site Admin edition.

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


3 years ago

#6 @hnla
3 years ago

It does look really good I wouldn't change much at all.

However I have one question you have been pointing out contrast issues on Nouveau and fixing on legacy so are we really saying the above grey text on grey background passes contrast tests ? ;) :)

@mercime
3 years ago

#7 @mercime
3 years ago

Updated patch adds @dcavins' corrections for my typos :)

#8 @mercime
3 years ago

@hnla Per my check, our text color in Welcome Screen has sufficient color contrast with the gray background :)

We have a problem with the color contrast of the BP notification bubble in wp-toolbar, but that's for another release as the replacement color which meets guidelines doesn't look as good.

#9 @mercime
3 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 11183:

Update Welcome Screen for BuddyPress 2.7.0.

Props mercime, dcavins, DJPaul, hnla.
Fixes #7267.

@mercime
3 years ago

final version as of BP RC1

#10 @slaFFik
3 years ago

  • Description modified (diff)
  • Resolution fixed deleted
  • Status changed from closed to reopened

#11 @slaFFik
3 years ago

  • Description modified (diff)

Found several typos:

unsuscribe
acceess
front end vs front-end
back end vs back-end
Improve performance by - I think Improved ... is better here.

Last edited 3 years ago by slaFFik (previous) (diff)

#12 @DJPaul
3 years ago

The changelog link should be e.g. http://codex.buddypress.org/releases/version-2-7-0/ (the placeholder page on the codex is nested incorrectly). Public instances of the version number should be displayed as "2.7" not "2.7.0" (I'm 99% sure this is how we've done it in the past for .0 releases).

Maybe change "For Devs and Site Admins" to "For Devs and site builders" to match the updated/new tag line (see the readme.txt). ?

#13 @hnla
3 years ago

@mercime @slaFFik

For consideration:

in the front-end

I would tend to say 'on' rather than 'In the front-end'?

I would tend to think that front-end as a phrase in this way should be capitalised Front-end?

we've changed 'Site Administrator' to 'builder' is that correct?

#14 @slaFFik
3 years ago

@hnla
Admin=>Builder - yes, readme.txt has this wording, as Paul wrote above.

Front-end - as I can see capitalized only titles, not the description text, so I would leave as is.

There are 2 places with in the front-end, and I tend to agree with you for both places. I will update the patch with this fix.

What about the back-end? Didn't find info about this, can't make a decision as not a native English speaker. We need to cast @boonebgorges here :)

#15 @hnla
3 years ago

@slaFFik
'back-end' is a loose term for server side generally, I think it's used quite frequently to refer to the admin dashboard but whether that is correct or appropriate? or am I confusing things?

Admin=>Builder - yes, readme.txt has this wording, as Paul wrote above.

Ah ok missed that.

#16 @slaFFik
3 years ago

@hnla

Yeah, I know its usage, you are right. :)
I'm not sure whether it's on the back-end or in the back-end :)
So decided to leave as is.

#17 @hnla
3 years ago

@slaFFik Yep leave as is oddly back-end suits being referred to as 'in' in that it's sort of hidden and we're 'in it' rather than front-end where we're displaying/rendering so the 'things' are 'on' it.

#18 follow-up: @boonebgorges
3 years ago

"Front-end" vs "frontend" vs "front end" seems mainly a question of house style. I don't have a strong preference. But WordPress standardized on two words for the noun ("on the front end") and hyphenated for the adjective ("improved front-end performance"), so maybe we should follow them: https://core.trac.wordpress.org/changeset/36709

#19 in reply to: ↑ 18 @slaFFik
3 years ago

Replying to boonebgorges:

"Front-end" vs "frontend" vs "front end" seems mainly a question of house style. I don't have a strong preference. But WordPress standardized on two words for the noun ("on the front end") and hyphenated for the adjective ("improved front-end performance"), so maybe we should follow them: https://core.trac.wordpress.org/changeset/36709

And what about on/in the back end? I didn't find any such string in that commit, not sure about the wording. Could you please clarify?

Last edited 3 years ago by slaFFik (previous) (diff)

#20 follow-up: @boonebgorges
3 years ago

Oh, sorry - I didn't fully answer your question :) "*On* the front end" sounds right to me.

#21 in reply to: ↑ 20 @slaFFik
3 years ago

Replying to boonebgorges:

Oh, sorry - I didn't fully answer your question :) "*On* the front end" sounds right to me.

I fill bad, but I was talking about back end :)

#22 @boonebgorges
3 years ago

Right - to my ear, it's the same. "On the back end".

#23 @slaFFik
3 years ago

Ok, thanks, I will update the patch today.

#24 @hnla
3 years ago

in the back end - ask an American for english lessons :rolleyes: :p

#25 @slaFFik
3 years ago

@hnla has a :trollface: right now.

C'mon guys, come to some conclusion :)
I'm a desperate (at this moment) Ukrainian guy who is not a native English speaker.

#26 @hnla
3 years ago

@slaFFik sorry was just playing the fool, please do go with Boone's suggestions. :)

Last edited 3 years ago by hnla (previous) (diff)

@slaFFik
3 years ago

Hopefully the last one, front/back([-| ])end

#27 @hnla
3 years ago

@mercime we appear to have omitted ticket/task #7226 it was a considerably largish ticket and provides a lot of improved functionality for devs so ought to be in main block.

#28 @mercime
3 years ago

Good morning and many thanks to everyone for your great feedback! :D

Thank you for the patches @slaFFik.

@hnla you are correct. Don't know why I missed that and #6544 which is awesome too. Will be adding both in a little while.

#29 @hnla
3 years ago

and #6544 which is awesome too

oops yes indeed, just checked that in case of template changes but all core stuff.

@mercime
3 years ago

#30 @mercime
3 years ago

Updated patch

  • Adds #6544 and #7226 - Comments/Improvements welcome
  • Moves some features around
  • Adds style support for new <code> markup

@dcavins
3 years ago

Text changes

#31 @mercime
3 years ago

@dcavins Thank you once again :)

@r-a-y @hnla any improvements on the Site Icon and BP_Buttons features added to the Welcome Screen or other stuff? Will be committing this tonight. Cheers.

#32 @hnla
3 years ago

The re-opening for bp_buttons feature just catches a small booboo so not a feature update as such but correction.

#33 @mercime
3 years ago

The re-opening for bp_buttons feature just catches a small booboo so not a feature update as such but correction.

@hnla Not clear what you mean :( Could you please clarify what specifically needs to be changed?

#34 @hnla
3 years ago

@mercime sorry think I got wrong end of stick, nothing needs changing all looks ok.

#35 @r-a-y
3 years ago

For the Site Icon feature, perhaps we can link to WP's existing codex article about this:
https://codex.wordpress.org/Creating_a_Favicon#WordPress_Version_4.3_or_later

Perhaps we could change the verbiage to

If you have used the Site Icon feature in WordPress 4.3+, BuddyPress will now use your Site Icon as the blog (site?) avatar (photo?) in the Sites Directory. Find out how to use the Site Icon feature here.

(I always get confused as to whether we refer to the Sites component as a site or a blog and whether we should use avatar or photo.)

Or shorter form:

Find out how to use the Site Icon feature from the Customizer panel here.

Feel free to tweak as needed or to disregard this altogether :)

#36 @DJPaul
3 years ago

On the "one day we should do something about this" list, we should create a glossary so we don't get confused about terminology to use. You're correct that instead of "avatar", we switched to "photo", some releases ago. "Avatar" should only appear internally in the code.

We renamed whatever the Blogs component was called to "Site Tracking" some time ago, so let's try to use "Site" for new strings.

Traditionally we string-freeze at RC, so if we're going to make this change to the strings, let's make this the last.

@mercime
3 years ago

#37 @mercime
3 years ago

@r-a-y Thank you. Added the link to the WP codex article.

Title: Use the Site Icon as Your Site’s Profile Photo for the Sites Directory Page
Text: BuddyPress sets the site admin’s profile photo as the default image for a new site. Now, you can <a href="https://codex.wordpress.org/Creating_a_Favicon#WordPress_Version_4.3_or_later">use the Site Icon feature introduced in WordPress 4.3</a> instead.

I've got 3 "sites" in the title ¯\_(ツ)_/¯

@DJPaul Thanks.

New patch and screenshot attached.

#38 @mercime
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 11188:

Update Welcome Screen items.

  • Fix typos
  • Add two features
  • Improve code
  • Add translator comments

Props slaFFik, dcavins, DJPaul, hnla, boonebgorges, mercime.
Fixes #7267.

#39 @mercime
3 years ago

@r-a-y Sincere apologies. I just noticed that I has missed your name in the props for the latest commit :( I promise to double-check props next time.

Note: See TracTickets for help on using tickets.