Skip to:

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#7115 closed defect (bug) (fixed)

Activity Embeds and standalone BuddyPress Themes

Reported by: imath's profile imath Owned by:
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit


The activity embed feature has added some templates into the bp-legacy/buddypress/assets, working on BP Nouveau i've noticed the embedded activities were not displayed. The reason was that the embeds assets subfolder and its templates were missing. see

So i've solved the issue for BP Nouveau, but then i thought what will happen for Standalone BuddyPress themes like BP Default, Swifter, Boss or BuddyBoss etc..

Swifter is fine.

But here's what happens in my version of Boss:

And in BuddyBoss

Can somebody test BP Default because i'm doing some symlink manipulation that may be the reason why the blockquote is not converted to an iframe...

So i think we should at least write a post on bpdevel to warn theme designers they should test the beta and make sure their themes will support activity embeds!

I must say i'm completely amazed no theme designer reacted about it! They don't test betas ????

Attachments (1)

7115.bp-default.patch (810 bytes) - added by r-a-y 8 years ago.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in Slack in #buddypress by imath. View the logs.

8 years ago

#2 @r-a-y
8 years ago

  • Keywords has-patch added

Thanks imath for testing with bp-default. bp-default.patch fixes older bp-default themes.

If anyone can pass me a copy of Boss, I can take a closer look.

Regarding new template packs, these are a few notes I left in the bp-nouveau thread:

Some quotes:

maybe we should adopt what WordPress does and have core theme-compat templates. Is that a crazy idea?


About the embed CSS files, maybe we can move them from /bp-legacy/assets/embeds/ to /bp-legacy/css to suit how other CSS files are located in bp-legacy?

Last edited 8 years ago by r-a-y (previous) (diff)

#3 @imath
8 years ago

  • Keywords commit added

@r-a-y i confirm it's fixing the issue for BP Default. I think you should commit it.

#4 @r-a-y
8 years ago

In 10879:

Embeds: Add support for bp-default themes.

bp-default uses a brute-force approach to loading templates. For embed
templates to render, we must wipe out any located bp-default template when
an embed page is being requested.

This allows the WordPress embed template to load as expected when a
bp-default theme is currently active.

See #7115.

#5 @r-a-y
8 years ago

  • Keywords needs-docs removed

I've added a codex article for this here -

Feel free to make additional changes.

Anything else that needs to be done here?

#6 @imath
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

I don't think so, thanks a lot @r-a-y :)

#7 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.