Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#7114 closed enhancement (fixed)

XProfile: Do not duplicate populate logic in BP_XProfile_Field

Reported by: r-a-y Owned by: r-a-y
Priority: normal Milestone: 2.7
Component: Extended Profile Version: 2.4.0
Severity: normal Keywords: has-patch commit
Cc:

Description (last modified by r-a-y)

While debugging #7112, I saw some duplicate DB logic that we can remove.

The $wpdb->get_row() call is duplicated in both BP_XProfile_Field::populate() and BP_XProfile_Field::get_instance() DB methods.

Attached patch merges the logic into the populate() method and passes existing unit tests.

Attachments (1)

7114.01.patch​ (1.4 KB ) - added by r-a-y 10 years ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
10 years ago

#1 @r-a-y
10 years ago

  • Description modified (diff)
  • Summary XProfile: Do not duplicate caching logic in BP_XProfile_Field → XProfile: Do not duplicate populate logic in BP_XProfile_Field

#2 @DJPaul
10 years ago

  • Milestone Awaiting Review → 2.7

Looks good

#3 @DJPaul
10 years ago

  • Keywords commit added

#4 @r-a-y
10 years ago

  • Owner set to r-a-y
  • Resolution → fixed
  • Status new → closed

In 10948:

XProfile: Do not duplicate populate logic in the BP_XProfile_Field class.

Previously, the $wpdb->get_row() call was duplicated in both the
BP_XProfile_Field::populate() and BP_XProfile_Field::get_instance() DB
methods.

This commit merges the logic into the BP_XProfile_Field::populate()
method and passes existing unit tests.

Fixes #7114.

Note: See TracTickets for help on using tickets.