Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7094 closed enhancement (fixed)

Enhancement: Please Introduce members pagination to bottom of Manage > Members on Group

Reported by: garrett-eclipse Owned by: dcavins
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5.0
Component: Groups Keywords:
Cc:

Description

Hello,

Within the groups/single/admin.php the members listing only provides the pagination at the top of the list, would like it to be introduced to top and bottom which is especially useful for longer lists or if one updates the per_page to be a larger number as the pagination gets lost once you scroll down.

This is already done on the Members tab of a Group but would like that same pagination at top and bottom for the Manage Members listing.

Thank you

Attachments (2)

7094.01.diff (4.4 KB) - added by dcavins 4 years ago.
Modest structural improvements to the group > manage > members screen.
7094.pag-only.2.diff (842 bytes) - added by dcavins 4 years ago.
Add pagination block only.

Download all attachments as: .zip

Change History (8)

#1 @hnla
4 years ago

@garrett-eclipse This sort of falls into one of those areas mentioned before this is tricky, I do not disagree and part of what my aim has always been with revising templates is to deal with a lot of aspects like this, but to make this type of change for existing bp-legacy templates would mean sites would suddenly have an elements appear that had perhaps been unplanned for.

This is definitely something I will address in the new templates.

Until such time as we introduce new templates I think this will have to remain a dev custom template override provision.

#2 @dcavins
4 years ago

This is something I've been meaning to add, too. (Also @hnla's recent updates to the group membership requests pane reminded me about how much I wanted to update this template.)

@garrett-eclipse You've been making lots of interesting tickets; are you ready to create patches? Anything we can do to help you get your dev environment set up?

@dcavins
4 years ago

Modest structural improvements to the group > manage > members screen.

#3 @boonebgorges
4 years ago

  • Component changed from API to Component - Groups
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

but to make this type of change for existing bp-legacy templates would mean sites would suddenly have an elements appear that had perhaps been unplanned for.

This does not seem like a problem to me. It's difficult for me to imagine a case where (a) the site is using the default /groups/single/members template, and (b) the site owner would have a problem with pagination being enabled for the pages. I *can* imagine a case where someone has implemented something like infinite scroll on a page like this (though it's extremely unlikely), but in this case the user would have overridden the template, so wouldn't see the new pagination anyway.

I understand the impulse to be conservative about making potentially disruptive changes to existing templates, but this hardly seems like a case that could realistically cause problems.

#4 @hnla
4 years ago

This does not seem like a problem to me. It's difficult for me to imagine a case where (a) the site is using the default /groups/single/members template, and (b) the site owner would have a problem with pagination being enabled for the pages.

Ok patch bp-legacy then no sweat.

@dcavins
4 years ago

Add pagination block only.

#5 @dcavins
4 years ago

  • Owner set to dcavins
  • Resolution set to fixed
  • Status changed from new to closed

In 10848:

Add pagination below members section on groups manage > admin template.

Add another pagination control below the members section,
mimicking the layout of other directory lists.

Fixes #7094.

Props dcavins.

#6 @r-a-y
4 years ago

  • Keywords needs-patch removed
  • Milestone changed from Future Release to 2.6
Note: See TracTickets for help on using tickets.