Context Navigation

← Previous Ticket
Next Ticket →

#7083 closed enhancement (fixed)

Harmonize structure of radio and check box input groups.

Reported by:	offereins	Owned by:
Milestone:	2.6	Priority:	low
Severity:	minor	Version:	2.5.0
Component:	Extended Profile	Keywords:	has-patch commit
Cc:	dcavins

Description

Radio button options have been wrapped in a div; checkbox options are not. Offereins suggested that these two structures be parallel.

I agree; I can't see how adding a basically anonymous div would change the layout in a meaningful way.

Attachments (11)

7083.01.diff (973 bytes) - added by dcavins 8 years ago.: Xprofile checkboxes: add div wrapping options
7083.02.diff (1.8 KB) - added by dcavins 8 years ago.: Also give the option wrapper div a useful class name for CSS targeting.
profile-edit-front-end.png (38.9 KB) - added by dcavins 8 years ago.: Front end form.
profile-fields-set-up.png (30.0 KB) - added by dcavins 8 years ago.: WP Admin form set up.
7083.03.patch (1.8 KB) - added by imath 8 years ago.
7083.4.diff (6.0 KB) - added by dcavins 8 years ago.: Wrap radio buttons options, checkbox options and datebox selects in div.
7083-admin-css.patch (4.9 KB) - added by mercime 8 years ago.: Add style support for Users > Extended Profiles screen
legends-styling-webkit.png (34.1 KB) - added by dcavins 8 years ago.: Styling in Chrome/Safari
legends-styling-firefox.png (32.0 KB) - added by dcavins 8 years ago.: Styling in Firefox
7083-admin-css.2.patch (12.2 KB) - added by dcavins 8 years ago.: Use .input-options instead of div:not(.field-visibility-settings) in CSS selector. Also use a float on the legend for Firefox compat.
legends-styling-webkit-small-screen.png (34.9 KB) - added by dcavins 8 years ago.: Webkit, narrow screen

Download all attachments as: .zip

Change History (22)

@dcavins
8 years ago

Attachment 7083.01.diff added

Xprofile checkboxes: add div wrapping options

#1 @DJPaul
8 years ago

We use this #field_ ID for the radio buttons template. What happens if both types of profile field are on the same screen? Either viewing, or editing, or managing/creating new fields? Does this situation occur?

@dcavins
8 years ago

Attachment 7083.02.diff added

Also give the option wrapper div a useful class name for CSS targeting.

#2 @dcavins
8 years ago

Hi Paul-

I don't think anything happens. The IDs are unique (they're based on the ID of the profile field), so unless some JS is hunting for divs with an ID starting with field_, I think we're OK. I'll upload some screen shots.

Let me know if I haven't answered your question.

-David

@dcavins
8 years ago

Attachment profile-edit-front-end.png added

Front end form.

@dcavins
8 years ago

Attachment profile-fields-set-up.png added

WP Admin form set up.

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.

8 years ago

This ticket was mentioned in Slack in #buddypress by imath. View the logs.

8 years ago

#5 @imath
8 years ago

hi @dcavins as discussed during last week dev chat (sorry i'm replying to this ticket this late!!) i found it weird to use sprintf and then concatenate the strings at the end.

So i'm suggesting 7083.03.patch