Skip to:
Content

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#7080 closed enhancement (fixed)

Fix Layout in wp-admin User > Extended Profile screen

Reported by: mercime Owned by: mercime
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Extended Profile Keywords: commit reporter-feedback
Cc:

Description

Markup improvements in #6678 for the front end - notably using fieldsets for checkbox, datebox, and radio buttons fields - has affected the styles in our w-admin User > Extended Profiles screen in the back end.

In addition, the datebox, the screen reader labels for date, month, and year are showing up because class="bp-screen-reader-text" is hardcoded in in class-bp-xprofile-field-type-datebox.php

To do:

  1. Add style support for the new legend element in the Extended Profiles screen.
  2. Add is_admin() conditional inside the class attribute to render screen-reader-text value for WP admin screen and render bp-screen-reader-text for the front-end Profile screen.

Patch and screenshots coming up.

Attachments (5)

7080.patch (3.8 KB) - added by mercime 17 months ago.
xprofile-admin-fields-be4.png (24.1 KB) - added by mercime 17 months ago.
Screen before patch
xprofile-admin-fields-new.png (12.9 KB) - added by mercime 17 months ago.
Screen after patch
xprofile-bptrunk-wp-4-0-11.PNG (28.7 KB) - added by mercime 17 months ago.
Screenshot BP Trunk - WP 4.0.11
7080.1.patch (3.9 KB) - added by mercime 17 months ago.

Download all attachments as: .zip

Change History (13)

@mercime
17 months ago

@mercime
17 months ago

Screen before patch

@mercime
17 months ago

Screen after patch

#1 @johnjamesjacoby
17 months ago

  • Keywords commit reporter-feedback added
  • Milestone changed from Awaiting Review to Under Consideration

This is great. Thanks for being on top of this.

How does this look for older versions of WordPress once we have the newer markup & styling support?

#2 @mercime
17 months ago

@johnjamesjacoby :) I applied the patch to test install - BP Trunk / WP 4.0.11 - and layout is fixed there as well. I need to increase the spacing between the "clear" link below the radio input fields and will upload revised patch for that in a little while.

Also just noticed that I will need to improve styles for this screen's mobile view, yikes. Will create a new ticket for this.

@mercime
17 months ago

Screenshot BP Trunk - WP 4.0.11

#3 @johnjamesjacoby
17 months ago

Also just noticed that I will need to improve styles for this screen's mobile view, yikes

Mobile UI/UX on this page has never been great, so we are okay to make incremental improvements here.

Keep up the great work!

@mercime
17 months ago

#4 @mercime
17 months ago

In 10798:

xProfiles A11y: Use correct value for screen reader class.

Generate "bp-screen-reader-text" for the front-end xProfile screens
and "screen-reader-text" in and wp-admin xProfile screens.

See #7080.

#5 @mercime
17 months ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10799:

xProfiles: Fix layouts of checkbox, datebox, radio fieldsets in wp-admin.

Provide style support in wp-admin > User > Extended Profile screen
after the introduction of fieldset wrappers for the xProfile field
types mentioned above in #6678.

Fixes #7080.

#6 @mercime
17 months ago

  • Milestone changed from Under Consideration to 2.6

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


17 months ago

#8 @dcavins
17 months ago

In 10856:

Xprofile: Fix layout issues with input types in wp-admin.

Align input fields on the extended profile
pane of a user’s profile in wp-admin.

See #7080.

Props mercime, dcavins.

Note: See TracTickets for help on using tickets.