Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6999 closed enhancement (fixed)

"BP Email to WP Mail From Bridge" plugin should be in core?

Reported by: slaffik's profile slaFFik Owned by: djpaul's profile djpaul
Milestone: 2.5.3 Priority: normal
Severity: normal Version:
Component: Emails Keywords: needs-patch
Cc:

Description (last modified by slaFFik)

I'm talking about this plugin: https://wordpress.org/plugins/bp-email-to-wp-mail-from-bridge/

I'm pretty sure, that the code of this plugin (just 1 function) should be in core.
Most of users just don't know that BP Emails "forked" wp_mail(), so they will be surprised, that their filters don't work.

Change History (6)

#1 @slaFFik
8 years ago

  • Description modified (diff)

#2 @DJPaul
8 years ago

Developers know the filter doesn't work, site owners only know that, maybe, emails aren't being delivered since 2.5. The decision at launch was to require people to re-implement such filters using our new API, but, it turns out that SMTP is a very finicky beast.

I have been tracking as many email support threads on the forums as I can since the 2.5 release. From sites/owners I have spoken to, the absence of wp_mail_from and/or wp_mail_from_name filters does seem to cause certain SMTP servers to refuse to deliver email depending on configuration, though I am still following up with 2 or 3 people via email to be 100% sure. At least, I can ask them now to try this plugin to easily prove/disprove this.

#3 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to 2.5.3

Yes, we should do this for 2.5.3.

@thebrandonallen I know it's a relatively simple filter plugin, but FYI. Thanks for building a convenient plugin to let the community have an option in the interim, and for providing an easy way to get regular users to test a proposed change. :)

#4 @DJPaul
8 years ago

  • Keywords needs-patch added

#5 @djpaul
8 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10696:

Emails: add support for wp_mail_from and wp_mail_from_name filters.

Improves compatibility with plugins that configure WordPress to send emails via SMTP.

Fixes #6999

Props thebrandonallen

#6 @djpaul
8 years ago

In 10697:

Emails: add support for wp_mail_from and wp_mail_from_name filters

Improves compatibility with plugins that configure WordPress to send emails via SMTP.

Fixes #6999 (2.5 branch)

Props thebrandonallen

Note: See TracTickets for help on using tickets.