#6969 closed defect (bug) (fixed)
BP Emails - friendship accepted email is not sent
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.5.2 | Priority: | normal |
Severity: | normal | Version: | 2.5.0 |
Component: | Emails | Keywords: | has-patch commit |
Cc: | s |
Description
Reports of friendship accepted emails not being sent.
https://buddypress.org/support/topic/do-not-send-one-email-in-buddypress-2-5/
Confirmed by me in BP 2.5.1
The 'friendship requested' email is sent.
Attachments (2)
Change History (10)
#1
@
8 years ago
- Milestone changed from Awaiting Review to 2.5.2
- Owner set to r-a-y
- Status changed from new to reviewing
#2
@
8 years ago
- Keywords has-patch added
- Status changed from reviewing to accepted
- Version set to 2.5.0
#3
@
8 years ago
I would prefer we typecast the numeric string to an int when we pass it to bp_send_email() -- the email classes themselves are pretty typestrict by design/intention.
#4
@
8 years ago
I would prefer we typecast the numeric string to an int
I guess we go the broad route then! Check out 02.patch
.
#5
@
8 years ago
- Keywords commit added
@r-a-y I was more referring to changing the token value in friends_notification_accepted_request()
rather than changing it upstream, but I don't care particularly where it's done. Thanks for looking into this!
Confirmed.
Bug occurs when a numeric string is passed to
BP_Email_Recipient
instead of an integer.The
$initiator_id
infriends_notification_accepted_request()
uses a numeric string, which is why the email fails to send because no recipient is parsed correctly inBP_Email_Recipient
.I suggest patching
BP_Email_Recipient
to useis_numeric()
instead ofis_int()
to fix this problem. A broader solution would be to audit all our access methods and functions to ensure that numeric strings are cast as integers or to useis_numeric()
where needed.