Changeset 10683

Timestamp:

03/23/2016 05:12:36 PM (9 years ago)

Author:

r-a-y

Message:

Friends: Fix issue with friendship accepted email not being sent.

Previously, the $initiator_id variable in friends_notification_accepted_request()`
was a numeric string. The BP_Email_Recipient class can only handle
strict integers, which prevented friendship accepted emails from being
sent.

For 2.5-branch, this commit casts $initiator_id variable as an integer
to fix the immediate problem. A broader solution to audit all our access
methods and functions to ensure that numeric strings are cast as
integers will be implemented in a future release.

Fixes #6969 (2.5-branch).

File:

• branches/2.5/src/bp-friends/bp-friends-notifications.php (modified) (1 diff)

branches/2.5/src/bp-friends/bp-friends-notifications.php

@@ -60 +60 @@
  */
 function friends_notification_accepted_request( $friendship_id, $initiator_id, $friend_id ) {
-    if ( 'no' == bp_get_user_meta( (int) $initiator_id, 'notification_friends_friendship_accepted', true ) ) {
+    $initiator_id = (int) $initiator_id;
+
+    if ( 'no' == bp_get_user_meta( $initiator_id, 'notification_friends_friendship_accepted', true ) ) {
         return;
     }