Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6955 closed enhancement (fixed)

Default Name field (id=1) is autolinked

Reported by: slaFFik Owned by: slaFFik
Milestone: 2.6 Priority: normal
Severity: normal Version: 1.0
Component: Extended Profile Keywords: good-first-bug has-patch
Cc:

Description

Which is useless, as this name is in 99% unique. There is also no ability (via GUI) to disable this new autolinking.

I propose to enable Autolinking switcher for this field.

Attachments (1)

6955.patch (1.7 KB) - added by slaFFik 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @slaFFik
5 years ago

  • Summary changed from Default Name fields in autolinked to Default Name field (id=1) is autolinked

#2 @DJPaul
5 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement
  • Version changed from 2.5.0 to 1.0

Yes.

The name field has special behaviour hardcoded, I don't know how easy this will be to change, but I'm tagging it good-first-bug in case someone is feeling brave. :)

@slaFFik
5 years ago

#3 @slaFFik
5 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to slaFFik
  • Status changed from new to assigned

#4 @slaFFik
5 years ago

  • Milestone changed from Future Release to 2.6

#5 @djpaul
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 10657:

xprofile: don't auto-link the Name field to a search.

Display names ought to be almost always unique. Performing a member
directory search on the default "Name" field (auto-linked) is only
going to retrieve the member whose profile you were on when you clicked
the search link.

Removing this hardcoded exception allows site administrators to choose
whether this field is auto-linked via the existing wp-admin Extended
Profiles metaboxes.

Fixes #6955

Props slaFFik

Note: See TracTickets for help on using tickets.