Changeset 10657

Timestamp:

03/16/2016 08:19:44 PM (8 years ago)

Author:

djpaul

Message:

xprofile: don't auto-link the Name field to a search.

Display names ought to be almost always unique. Performing a member
directory search on the default "Name" field (auto-linked) is only
going to retrieve the member whose profile you were on when you clicked
the search link.

Removing this hardcoded exception allows site administrators to choose
whether this field is auto-linked via the existing wp-admin Extended
Profiles metaboxes.

Fixes #6955

Props slaFFik

Location:

trunk/src/bp-xprofile

Files:

• bp-xprofile-admin.php (modified) (1 diff)
• classes/class-bp-xprofile-field.php (modified) (2 diffs)

trunk/src/bp-xprofile/bp-xprofile-admin.php

@@ -419 +419 @@
 
                 // Save autolink settings.
-                if ( 1 != $field_id ) {
-                    if ( isset( $_POST['do_autolink'] ) && 'on' === wp_unslash( $_POST['do_autolink'] ) ) {
-                        bp_xprofile_update_field_meta( $field_id, 'do_autolink', 'on' );
-                    } else {
-                        bp_xprofile_update_field_meta( $field_id, 'do_autolink', 'off' );
-                    }
+                if ( isset( $_POST['do_autolink'] ) && 'on' === wp_unslash( $_POST['do_autolink'] ) ) {
+                    bp_xprofile_update_field_meta( $field_id, 'do_autolink', 'on' );
+                } else {
+                    bp_xprofile_update_field_meta( $field_id, 'do_autolink', 'off' );
                 }
 

trunk/src/bp-xprofile/classes/class-bp-xprofile-field.php

@@ -818 +818 @@
 
             if ( '' === $do_autolink ) {
-                $this->do_autolink = $this->is_default_field() || $this->type_obj->supports_options;
+                $this->do_autolink = $this->type_obj->supports_options;
             } else {
                 $this->do_autolink = 'on' === $do_autolink;
@@ -1457 +1457 @@
      */
     private function autolink_metabox() {
-
-        // Default field cannot have custom visibility.
-        if ( true === $this->is_default_field() ) {
-            return;
-        }
-
         ?>