Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6820 closed defect (bug) (fixed)

Invalid HTML in message form

Reported by: tfrommen Owned by: boonebgorges
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Messages Keywords: has-patch
Cc:

Description

When you choose someone to send a message to, a <li> tag for the according user will be inserted into the markup. The problem here is that this leads to nested <li> tags without a new list tag. For instance like so:

<ul class="first acfb-holder">
	<li>
		<li class="friend-tab" id="un-12345">
			...
		</li>
		<input type="text" id="send-to-input" ...>
	</li>
</ul>

Change History (3)

#1 @boonebgorges
4 years ago

  • Milestone changed from Awaiting Review to 2.5

Thanks for the ticket, @tfrommen. This autocomplete library is kinda odd: it expects the <input> field to be inside of an <li> in the same <ul> as the clicked results. There's an error in the JS that causes clicked results to be put inside of the input's list item, rather than alongside.

#2 @boonebgorges
4 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10447:

Ensure that Messages autocomplete selections result in valid HTML.

Previously, clicking a suggested user would result in a new <li> element
being nested inside of an existing <li>, rather than placed alongside.

Fixes #6820.

#3 @tfrommen
4 years ago

  • Keywords has-patch added; needs-patch removed
Note: See TracTickets for help on using tickets.