Skip to:

Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#6774 closed enhancement (fixed)

Re-factor Groups manage requests template

Reported by: hnla's profile hnla Owned by: hnla's profile hnla
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit


This ticket is prompted by #6771 and issues spotted and noted by @DJPaul.

On the screen that displays pending group join requests (i.e private group and user requests to join) we loop out requests by user currently that markup isn't ideal as optional user comments are rendered in the heading tag and this reads badly as well as being semantically poor. Styling across the twenty* style sheets is sub optimal but

  • Admin manage > sent requests screen pushes out the optional user reason to accept text nested in the heading element(h4) this is wrong and incorrect/inappropriate use of a heading element. that request text should be a paragraph and located outside the heading.
  • On request sent success screen in the group, our messages could be better displayed, currently we still display the request instruction message along with success request sent message but this pushes down the object nav and original message which looks clumsy.

This ticket will address the two points above, updating the user request comments text moving it out to it's own position after the heading, in a similar manner to other bp list elements meta handling, and attempt a better experience with the success screen when a user has made a request, removing original screen message and moving success message down below the object nav.

Styling across the twenty* style sheets is sub optimal as noted in the SC on the other ticker this will be addressed after template changes as the template changes will impact the styles, with some sheets probably not requiring much attention.

Attachments (2)

6774-01.patch (1.8 KB) - added by hnla 8 years ago.
Re-factor group request loop.
6774-refresh-01.patch (1.8 KB) - added by hnla 8 years ago.
Refresh patch.

Download all attachments as: .zip

Change History (14)

8 years ago

Re-factor group request loop.

#1 @hnla
8 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to hnla
  • Status changed from new to accepted

Patch 01 updates the request loop markup.

The markup for this template markedly differed from our other loops for list-items i.e members loops, group loops; this in a large part accounted for the styling issues seen. Bringing the markup into line, element and class wise, with our other loops ensures we inherit the same styling applied to the generic loops across the WP themes whether styled from the primary BP styles or the companion styles.

Although these are fairly major changes, this is more a template that ought originally to have been built as the other loops were, themes may see changes but overall those changes will be in keeping with our existing styles for loops.

#2 @hnla
8 years ago

Sadly the second point 'the success message' after requesting can't be dealt with as it would require rethinking how we push out the top level messages as well as currently we have no means of telling what screen state we're in so can't easily remove the 'no access' message displayed while waiting for approval.

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.

8 years ago

#4 @DJPaul
8 years ago

  • Milestone changed from 2.5 to 2.6

#5 @DJPaul
8 years ago

  • Keywords needs-refresh added; has-patch removed

8 years ago

Refresh patch.

#6 @hnla
8 years ago

  • Keywords has-patch added; needs-refresh removed

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.

8 years ago

#8 @dcavins
8 years ago

@hnla This looks good to me and is a vast improvement over the current markup.

#9 @hnla
8 years ago

I'll review and commit if you're in agreement then?

#10 @dcavins
8 years ago

  • Keywords commit added

Yes please.

#11 @hnla
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 10813:

Re-factor Group requests loop template

Commit addresses issues with member display in loops where heading element is used to render user name and user request comments.

Commit removes heading and removes user comments to a more appropriate paragraph tag.

This brings the request loop into closer parity to other generic loops of this type.

Fixes #6774

#12 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.