Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#6771 closed defect (bug) (wontfix)

Reason not clearly shown on Groups - Request screen in twenty* themes.

Reported by: DJPaul Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords: needs-patch
Cc: hnla

Description

On a URL such as http://buddypress.dev/groups/xxx/admin/membership-requests/ as an group admin user when there are membership requests pending, the optional reason (for asking to join a group) is shown immediately next to the requester's name. Depending on theme styling, the reason can look like it's part of the name (there may also be accessibility problems with the same thing).

Attachments (6)

2010.png (33.8 KB) - added by DJPaul 5 years ago.
2011.png (33.3 KB) - added by DJPaul 5 years ago.
2012.png (33.7 KB) - added by DJPaul 5 years ago.
2013.png (51.3 KB) - added by DJPaul 5 years ago.
2015.png (87.0 KB) - added by DJPaul 5 years ago.
2014.png (82.5 KB) - added by DJPaul 5 years ago.

Download all attachments as: .zip

Change History (19)

@DJPaul
5 years ago

@DJPaul
5 years ago

@DJPaul
5 years ago

@DJPaul
5 years ago

@DJPaul
5 years ago

@DJPaul
5 years ago

#1 @DJPaul
5 years ago

I noticed this on 2015 -- as you can see, it's very hard to tell the difference.

#2 @hnla
5 years ago

So easy to miss stuff like this - need a check list of all screen states/events to work from when working on BP layouts.

Looking at those SC it's not just styling but that it's not clear what that random string announcing ones hotness is about - we'll need to look at styling and perhaps making things clearer as to what the text is?

#3 @hnla
5 years ago

In fact how do get to that text, I don't have that when I request membership of a private group!?

#4 @DJPaul
5 years ago

Yeah, private group - and then get another user account to go to the group's homepage (not on the directory) and click "request to join" - it takes you to a page with a form where you enter a reason .

#5 @hnla
5 years ago

Yep, had forgotten the procedures and requested from the group directory.

We have a number of issues in reality here, covering both templates and styling.

Styling aside we do not have a great UI:

  • Two routes to applying or sending a request, one from action button on group dir screen and one from subnav screen in the group one automagically sends the request via Ajax without any further user input, the other allows the user to add a comment(optional)attached to their request.
  • Admin manage > sent requests screen pushes out the optional user reason to accept text nested in the heading element(h4) this is wrong and incorrect/inappropriate use of a heading element. that request text should be a paragraph and located outside the heading.
  • On request sent success screen in the group, our messages could be better displayed, currently we still display the request instruction message along with success request sent message but this pushes down the object nav and original message which looks clumsy.
  • Styling of the groups screens need attention, The li items should in theory have picked up more generic styling than they appear to have so that needs addressing as the lists are essentially just a member list in terms of layout.

Styling is a nuisance as all the twenty* files will need updating (probably) but more importantly we'll need to do a little work on the templates or the request list screen in particular. I'll look at breaking out a new ticket to cover some template updates.

Last edited 5 years ago by hnla (previous) (diff)

#6 @DJPaul
5 years ago

I don't think we need to address your first bullet point with these set of changes. It's been like it is for a very long time, and I'm confident it's not worth changing that AJAX flow because we'll probably break everyone's template by doing so.

#7 @hnla
5 years ago

Fair enough on 1 but it's just 'bad' the action button should have pointed to the group screen and should not have actioned the request per se.

Points 2 & 3 will need addressing but then could equally break peoples layouts but we can't just style ourselves out of problems :(

#8 @r-a-y
5 years ago

Maybe we can do something simple with CSS :before and the dashicons font (perhaps the clipboard or quotation icon?) and make it look like a stylized blockquote?

#9 @DJPaul
5 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.5 to Future Release

#10 @hnla
5 years ago

@DJPaul There was a patch on: #6774 that addressed aspects that could be dealt with.

#11 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates

#12 @DJPaul
3 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#13 @DJPaul
3 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.