Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6767 closed defect (bug) (fixed)

Cannot use object of type Closure as array in bp-core-filters.php

Reported by: gantry Owned by:
Milestone: 2.4.4 Priority: normal
Severity: major Version: 2.4.0
Component: Core Keywords: has-patch
Cc:

Description

BuddyPress needs additional check to make sure that callback is array, as it can be also a Closure.

( ! ) Fatal error: Cannot use object of type Closure as array in /Users/xxx/Sites/wp/wp-content/plugins/buddypress/bp-core/bp-core-filters.php on line 1104

Attachments (1)

6767.01.patch (603 bytes) - added by r-a-y 5 years ago.

Download all attachments as: .zip

Change History (8)

#1 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.4.3
  • Priority changed from high to normal
  • Severity changed from normal to major

Yes, good catch.

Will put in 2.4.3 milestone but will probably be 2.4.4 (after xmas). Anyone affected can use this temporary workaround:

remove_filter( 'dynamic_sidebar_params', '_bp_core_inject_bp_widget_css_class' );

#2 @imath
5 years ago

  • Milestone changed from 2.4.3 to 2.4.4

Moving this ticket to 2.4.4 milestone. Thanks DJPaul for sharing the temporary fix.

#3 @r-a-y
5 years ago

  • Keywords has-patch added
  • Version set to 2.4.0

Ugh... sorry! This is my fault.

Attached patch should fix this.

@gantry - Can you give it a try?

@r-a-y
5 years ago

#4 @gantry
5 years ago

Fix confirmed :) Thanks!

#5 @r-a-y
5 years ago

In 10566:

Widgets: Do not attempt to inject 'buddypress' CSS class for closure callbacks.

Anti-props r-a-y.

See #6767 (2.4-branch)

#6 @r-a-y
5 years ago

In 10567:

Widgets: Do not attempt to inject 'buddypress' CSS class for closure callbacks.

Anti-props r-a-y.

See #6767 (trunk)

#7 @r-a-y
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.