#6758 closed enhancement (fixed)
Travis CI: Remove PHP7 from allowed failures list and test PHP nightly builds
Reported by: | netweb | Owned by: | djpaul |
---|---|---|---|
Milestone: | 2.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch |
Cc: |
Description
PHP 7 has now been officially released:
https://twitter.com/official_php/status/672511111896432640
We should update our Travis CI to not allow failures for PHP 7 and test PHP 7 nightly builds to allow to fail.
See also #WP33410 and https://make.wordpress.org/core/2015/09/10/wordpress-and-php7/
Attachments (2)
Change History (10)
#2
@
9 years ago
There be explosions with PHP 7 and WordPress versions < 4.3, 6758.1.diff excludes WordPress versions < 4.3 from the Travis CI test matrix.
#3
follow-up:
↓ 6
@
9 years ago
- Milestone changed from Awaiting Review to 2.5
What kind of explosions? Issues with PHP7 in WordPress core? A bit more info would have been useful. ;)
#4
@
9 years ago
I was able to update my dev env to PHP7 and did some light testing, so happy to add this in (now that at the least I'd be able to look at any failures).
#5
@
9 years ago
- Owner set to djpaul
- Resolution set to fixed
- Status changed from new to closed
In 10400:
#6
in reply to:
↑ 3
@
9 years ago
Replying to DJPaul:
What kind of explosions? Issues with PHP7 in WordPress core? A bit more info would have been useful. ;)
Thanks for getting this merged, an sorry, my bad, I didn't look much further than the PHP4 style constructors errors as they were the 1st things I noticed when I add this for same change for bbPress, and hence none of the PHP 7 work was back ported to WP versions pre 4.3 so once I had excluded those from the Travis build matrix all was resolved.
See also: https://make.wordpress.org/core/2015/07/02/deprecating-php4-style-constructors-in-wordpress-4-3/
And PHP 7 job errors here for bbPress: https://travis-ci.org/ntwb/bbPress/builds/94749040
See also #bbPress2895 and changeset:5958