Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#6758 closed enhancement (fixed)

Travis CI: Remove PHP7 from allowed failures list and test PHP nightly builds

Reported by: netweb Owned by: djpaul
Priority: normal Milestone: 2.5
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch
Cc:

Description

PHP 7 has now been officially released:

https://twitter.com/official_php/status/672511111896432640

We should update our Travis CI to not allow failures for PHP 7 and test PHP 7 nightly builds to allow to fail.

See also #WP33410 and https://make.wordpress.org/core/2015/09/10/wordpress-and-php7/

Attachments (2)

6758.diff (340 bytes ) - added by netweb 11 years ago.
6758.1.diff (689 bytes ) - added by netweb 11 years ago.

Download all attachments as: .zip

Change History (10)

@netweb
11 years ago

@netweb
11 years ago

#2 @netweb
11 years ago

There be explosions with PHP 7 and WordPress versions < 4.3, 6758.1.diff excludes WordPress versions < 4.3 from the Travis CI test matrix.

#3 follow-up: @DJPaul
11 years ago

  • Milestone Awaiting Review2.5

What kind of explosions? Issues with PHP7 in WordPress core? A bit more info would have been useful. ;)

#4 @DJPaul
11 years ago

I was able to update my dev env to PHP7 and did some light testing, so happy to add this in (now that at the least I'd be able to look at any failures).

#5 @djpaul
11 years ago

  • Owner set to djpaul
  • Resolutionfixed
  • Status newclosed

In 10400:

Travis-CI: run tests on PHP7 and remove from allowed failures.

Add exceptions for particular versions of WordPress which pre-date that project's PHP7 compatibility fixes.

Props netweb
Fixes #6758

#6 in reply to: ↑ 3 @netweb
11 years ago

Replying to DJPaul:

What kind of explosions? Issues with PHP7 in WordPress core? A bit more info would have been useful. ;)

Thanks for getting this merged, an sorry, my bad, I didn't look much further than the PHP4 style constructors errors as they were the 1st things I noticed when I add this for same change for bbPress, and hence none of the PHP 7 work was back ported to WP versions pre 4.3 so once I had excluded those from the Travis build matrix all was resolved.

See also: https://make.wordpress.org/core/2015/07/02/deprecating-php4-style-constructors-in-wordpress-4-3/

And PHP 7 job errors here for bbPress: https://travis-ci.org/ntwb/bbPress/builds/94749040

#7 @DJPaul
10 years ago

  • Component Tools - Build ProcessBuild/Test Tools

#8 @DJPaul
10 years ago

  • Type taskenhancement
Note: See TracTickets for help on using tickets.