Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#6738 closed defect (bug) (fixed)

Cover image - Group admin / mod avatars z-index issue

Reported by: r-a-y Owned by: hnla
Milestone: 2.4.2 Priority: normal
Severity: normal Version: 2.4.0
Component: Templates Keywords: has-patch commit
Cc:

Description

Reported here:
https://buddypress.org/support/topic/z-index-issue-with-2014-and-cover-images/

https://www.mantablog.nl/wp-content/uploads/cover-images-2014-dropdown-menu.png

Issue is reported on the Twenty Fourteen theme, but might exist on other themes.

Attachments (1)

6738.patch (600 bytes) - added by hnla 6 years ago.
Update stacking contexts for cover images containers.

Download all attachments as: .zip

Change History (11)

#1 @hnla
6 years ago

That's a good catch.
I'll have a look and see where/how we can best rectify, and check over the other themes.

Sort of suggests though the themes z-index for dropdown not being high enough e.g '500' +

#2 @hnla
6 years ago

  • Owner set to hnla
  • Status changed from new to reviewing

#3 @hnla
6 years ago

We have overstated the stacking indices really on the cover image elements groups. As we have created a new stacking context on the parent the child elements would naturally fall into default stacking order, we are stating '1' for first child element then '999' (trumping the WP menu styles ) for following element, within the new parent context '0'/'1' would have sufficed.

I'll patch buddypress.css shortly to adjust these values, after checking over the other WP themes and IE which historically took pos:abs out of context of it's parent causing issues.

@hnla
6 years ago

Update stacking contexts for cover images containers.

#4 @hnla
6 years ago

  • Status changed from reviewing to accepted

Patch updates the stacking contexts for the main cover image block groups/members header elements.

This patch corrects the issue of prior elements having a lower context (non position relative)

Tested across twenty* themes & IE9

The update re-sets the inner contexts to 1 & 2 respectively for the background image and BP item-avatar and item-actions container.

The parent container is set to '0'

This corrects a greater issue spotted in twentytwelve where the parent cover-image container having a higher context than the main menu completely overlays the dropdown menu, obscuring the majority of the menu items.

In reality setting the cover image parent wrapper to '0' is sufficient to correct the initial problem with high z-index, we'll set parent = '0' and within that context set the elements to '1' & '2' to be safe, stating the obvious in a sense.

#5 @r-a-y
6 years ago

  • Keywords has-patch commit added; needs-patch removed

Confirmed that this is fixing the problem.

Thanks hnla!

#6 @hnla
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 10366:

Update Cover Image stacking context.

Commit corrects an issue where cover image z-index for header elements are too high for dropdown navs with a low z-index potentially overlaying dropdowns. Re-sets parent cover image container to '0'

Fixes #6738 Props joost-abrahams r-a-y

#7 @r-a-y
6 years ago

In 10367:

Update Cover Image stacking context.

Commit corrects an issue where cover image z-index for header elements are
too high for dropdown navs with a low z-index potentially overlaying
dropdowns. Re-sets parent cover image container to '0'.

Fixes #6738 (2.4-branch)

#8 @r-a-y
6 years ago

hnla - FYI, I applied your commit from trunk to the 2.4-branch.

#9 @hnla
6 years ago

@r-a-y thanks for that, sorry to burden you with it, didn't occur to do that.

#10 @DJPaul
5 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.