Avatar src attribute must not contain the "d" param if the Gravatar logo is chosen under Settings > Discussion > Default Avatar

[henry.wright]

The ​Image Requests Gravatar article explains that the following image is shown when an email address has no matching Gravatar image:

The article goes on to say:

If you'd prefer to use your own default image (perhaps your logo, a funny face, whatever), then you can easily do so by supplying the URL to an image in the d= or default= parameter.

If this particular image is chosen in Settings > Discussion > Default Avatar, the src attribute in the image HTML must not contain the d parameter, else the image won't display.

Steps to reproduce:

1. Select the Gravatar logo under Settings > Discussion > Default Avatar
2. View a BuddyPress member who a) doesn't have an uploaded profile photo and b) doesn't have a Gravatar

[boonebgorges]

Wow, weird that we never noticed this before. Is it a recent change in the Gravatar API, or a regression on our part?

[henry.wright]

Not sure if the Gravatar API has a public changelog to find out? My guess is the Grav logo isn't a popular choice and in cases where it was chosen, a profile photo upload most probably took precedence so the problem wasn't noticed.

[r-a-y]

Thanks for the catch, @henry.wright.

This is my fault.

In #6622, when I added in the extra parameters from the 'get_avatar' filter from WordPress 4.2.0, I tacked on the 'd' parameter to Gravatar requests.

Looking into it.

[henry.wright]

Hi r-a-y,

I was thinking the fix could be to supply the d param conditionally, only when the default Grav isn't gravatar_default (see attached patch).

[r-a-y]

Thanks for the patch, @henry.wright.

02.patch is a slight tweak, but is basically the same thing.

Will commit later today. Thanks again!

[r-a-y]

In 10368:

Avatars: Fix issue when selecting 'Gravatar Logo' from 'Settings > Discussion > Default Avatar'.

If 'Gravatar Logo' was selected from the 'Settings > Discussion' admin
page, avatars on BuddyPress pages that did not have a valid Gravatar would
not display properly.

This is a regression due to changes in #6622.

Fixes #6737 (trunk).

Props henry.wright.

[r-a-y]

In 10369:

Avatars: Fix issue when selecting 'Gravatar Logo' from 'Settings > Discussion > Default Avatar'.

If 'Gravatar Logo' was selected from the 'Settings > Discussion' admin
page, avatars on BuddyPress pages that did not have a valid Gravatar would
not display properly.

This is a regression due to changes in #6622.

Fixes #6737 (2.4-branch).

Props henry.wright.

[r-a-y]

In 10370:

Tests: Fix avatar test due to changes in #6737.

See #6737.

[djpaul]

In 10389:

Tests: Fix avatar test due to changes in #6737. (2.4 branch)

See #6737.