Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6733 closed defect (bug) (fixed)

NEW search param misnamed

Reported by: modemlooper Owned by: boonebgorges
Milestone: 2.4.2 Priority: normal
Severity: normal Version: 2.4.0
Component: Members Keywords:
Cc:

Description

Boone fixed the front page search messing with ?s=

there are now specific component params but the keys dont match

?members_s=
?groups_search=
?activity_search=

why is members with _s and the others with search?

Change History (4)

#1 follow-up: @r-a-y
4 years ago

  • Component changed from Component - Core to Component - Members
  • Keywords reporter-feedback removed

Good spot! I think ?members_s is a typo.

The commit message in r10110 references ?members_search.

Last edited 4 years ago by r-a-y (previous) (diff)

#2 in reply to: ↑ 1 @boonebgorges
4 years ago

Replying to r-a-y:

Good spot! I think ?members_s is a typo.

The commit message in r10110 references ?members_search.

D'oh.

#3 @boonebgorges
4 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10363:

Use correct search_query_arg for members component.

[10110] introduced the wrong string. See #5087.

Props modemlooper.
Fixes #6733.

#4 @boonebgorges
4 years ago

In 10364:

Use correct search_query_arg for members component.

[10110] introduced the wrong string. See #5087.

Merges [10363] from the 2.4 branch.

Props modemlooper.
Fixes #6733.

Note: See TracTickets for help on using tickets.