Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6631 closed defect (bug) (fixed)

#profile-nav buttons bug

Reported by: daniluk4000 Owned by: djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.3.3
Component: Core Keywords: has-patch
Cc: daniluk4000@…

Description

On User Profile Edit page when the number of notifications => 4 see screenshot

Attachments (3)

thebug.png (35.6 KB) - added by daniluk4000 5 years ago.
nobug.png (43.1 KB) - added by daniluk4000 5 years ago.
After fix
6631.patch (1.2 KB) - added by daniluk4000 5 years ago.
patch

Download all attachments as: .zip

Change History (15)

@daniluk4000
5 years ago

#1 @daniluk4000
5 years ago

  • Cc daniluk4000@… added
  • Keywords has-patch added

How do I fix it:

div#profile-page.wrap form#your-profile {
    padding-top: 50px;
}

@daniluk4000
5 years ago

After fix

This ticket was mentioned in Slack in #buddypress by daniluk4000. View the logs.


5 years ago

#3 @slaFFik
5 years ago

  • Keywords has-patch removed

has-patch keyword is used when a 6631.patch file is attached, which is actually an SVN patch.

@daniluk4000
5 years ago

patch

#4 @daniluk4000
5 years ago

  • Keywords has-patch added

@slaFFik as you want

#5 @slaFFik
5 years ago

I believe, RTL file is auto-generated, some of the core devs will (or not) correct me in this.
Anyway, now it's much easier for core devs to apply your patch :)

And that's not just my wish, that's something I was told years ago when started submitting my first patches here too.

#6 @daniluk4000
5 years ago

@slaFFik
thanks anyway

Don't know about generating of RTL files

#7 @hnla
5 years ago

Thanks for the patch @daniluk4000 , looks like a good spot.

Not looked at this but did you check whether the parent element doesn't just need clearing. My concern with a fixed pixel padding would be if more admin notices appeared, does the padding keep things below any number of possible notices?

As for the rtl files they will be generated by the grunt task when the patch is committed.

#8 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.4

#9 @DJPaul
5 years ago

This was also reported in #6653

#10 @DJPaul
5 years ago

I think this is your first patch contribution to BuddyPress, daniluk4000! Thanks very much.

#11 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10274:

Members: fix position of xprofile tab on Edit User screen

Fixes overlap with the page title on the Page and Extended Profile tabs.
Also fixes overlap with any page notifications that may be introduced
by other plugins.

Fixes #6631

Props daniluk4000, slaFFik

#12 @DJPaul
4 years ago

  • Component changed from General - UX/UI to Core
Note: See TracTickets for help on using tickets.