Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#6653 closed regression

Extended Profile in wp-admin breaks Users screen CSS

Reported by: djpaul's profile DJPaul Owned by:
Milestone: Priority: high
Severity: major Version:
Component: Administration Keywords: has-patch
Cc:

Description

On Users > User Profile, the tabs at at top appear broken when on WP's "Profile" tab. When we're on BP's "Extended Profile" tab, it looks fine.

Screenshot http://cl.ly/image/253R2r2l0Y0j

Tested on some recent WP 4.4 trunk.

Attachments (1)

6653.patch (826 bytes) - added by mercime 9 years ago.

Download all attachments as: .zip

Change History (7)

#1 @DJPaul
9 years ago

Pinging @imath who wrote this and @mercime and @hnla, gurus of CSS. :D

#2 @hnla
9 years ago

That looks familiar has this not already been ticketed?

The issue is clearing either those tabs need 'clear: both' on the parent ul or clearfix/'overflow: hidden' to contain the li elements, then they should fall below the other element.

#3 @DJPaul
9 years ago

I don't think it is as easy as that. Those tabs are a bit of a hack, they are two anchors inside a wrapping h2 which is absolutely positioned from the top of the page. 😱

#4 @hnla
9 years ago

'tsk' I reads 'hack' 'anchors in h2', 'abs pos' :(

Was just having a look as it happens but can't see the issue in wp/bp bleeding edges.

@mercime
9 years ago

#5 @mercime
9 years ago

  • Keywords has-patch added; needs-patch removed

Attached patch fixes the issue caused by the bump in heading levels in WordPress admin panels for a11y, which we will be doing to our BP admin panels as well.

#6 @DJPaul
9 years ago

  • Milestone 2.4 deleted
  • Status changed from new to closed

Thanks for the patch, mercime,This does fix the issue but the amount whitespace is different on each tab. I'm going to go with the fix in #6631 as that seems to resolve this too.

Note: See TracTickets for help on using tickets.