Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6625 closed enhancement (fixed)

Accessibility: Form elements in bp-friends/

Reported by: mercime Owned by: mercime
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Friends Keywords:
Cc:

Description

Bind labels to form controls: add 'id' attributes to form controls as needed, add 'for' attributes to labels, and improve markup as needed.

Attachments (3)

bp-friends-widgets-checkbox-id.patch (1.2 KB) - added by mercime 4 years ago.
bp-friends-widgets-max-match-for-id.patch (1.3 KB) - added by mercime 4 years ago.
bp-friends-widgets-select-id-for.patch (1.4 KB) - added by mercime 4 years ago.

Download all attachments as: .zip

Change History (14)

#1 @mercime
4 years ago

Friends Widget: Correct the 'for' value of the label and add an 'id' attribute to checkbox field.
bp-friends-widgets-checkbox-id.patch

#2 @mercime
4 years ago

Friends Widget: Match 'for' value of label tag with 'id' value of text input field.
bp-friends-widgets-max-match-for-id.patch

Last edited 4 years ago by mercime (previous) (diff)

#3 @mercime
4 years ago

Friends Widget: Add new 'id' attribute to the select element and replace the label's 'for' value with that from the aforementioned 'id' value.
bp-friends-widgets-select-id-for.patch

Last edited 4 years ago by mercime (previous) (diff)

#4 @mercime
4 years ago

  • Keywords has-patch added

#5 @mercime
4 years ago

In 10111:

Friends Widget: Add 'id' attribute to input field and bind to label.

Accessibility fix to correct the label 'for' value and to match the
the newly created 'id' value of the checkbox input field to link
widget title to Members directory.

See #6625.

#6 @mercime
4 years ago

In 10112:

Friends Widget: Replace 'for' value with 'id' value of input field.

Accessibility fix which replaces the static 'for' value with the
dynamic 'id' value of the input field.

See #6625.

#7 @mercime
4 years ago

In 10113:

Friends Widget: Add 'id' attribute to input field and bind to label.

Accessibility fix adds dynamic 'id' value which also replaces the old
'for' value in order to avoid duplicate 'ids' in DOM when more than
one Friends Widget is added to a theme's available widget areas. This
also unwraps the label tag from the select field.

See #6625.

#8 @DJPaul
4 years ago

  • Milestone changed from Awaiting Review to 2.4

#9 @DJPaul
4 years ago

@mercime is this ticket resolved?

#10 @DJPaul
4 years ago

  • Keywords has-patch removed

#11 @mercime
4 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10251:

Add missing semicolons to previous commit for Friends widget.

Fixes #6625.

Note: See TracTickets for help on using tickets.