Changeset 10113

Timestamp:

09/17/2015 03:50:09 PM (11 years ago)

Author:

mercime

Message:

Friends Widget: Add 'id' attribute to input field and bind to label.

Accessibility fix adds dynamic 'id' value which also replaces the old
'for' value in order to avoid duplicate 'ids' in DOM when more than
one Friends Widget is added to a theme's available widget areas. This
also unwraps the label tag from the select field.

See #6625.

File:

• trunk/src/bp-friends/bp-friends-widgets.php (modified) (1 diff)

trunk/src/bp-friends/bp-friends-widgets.php

@@ -195 +195 @@
 
                 <p>
-                        <label for="bp-core-widget-friends-default"><?php _e( 'Default friends to show:', 'buddypress' ); ?>
-                        <select name="<?php echo $this->get_field_name( 'friend_default' ) ?>">
+                        <label for="<?php echo $this->get_field_id( 'friend_default' ) ?>"><?php _e( 'Default friends to show:', 'buddypress' ); ?></label>
+                        <select name="<?php echo $this->get_field_name( 'friend_default' ) ?>" id="<?php echo $this->get_field_id( 'friend_default' ) ?>">
                                 <option value="newest" <?php selected( $friend_default, 'newest' ); ?>><?php _e( 'Newest', 'buddypress' ) ?></option>
                                 <option value="active" <?php selected( $friend_default, 'active' );?>><?php _e( 'Active', 'buddypress' ) ?></option>
                                 <option value="popular"  <?php selected( $friend_default, 'popular' ); ?>><?php _e( 'Popular', 'buddypress' ) ?></option>
                         </select>
-                        </label>
                 </p>