Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6599 closed defect (bug) (fixed)

bp_get_the_thread_message_sender_id applies incorrect filter

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.3.3 Priority: normal
Severity: normal Version: 2.1
Component: Messages Keywords: commit
Cc:

Description

While reviewing bp-messages-template.php I noticed that the bp_get_the_thread_message_sender_id() function applies the bp_get_the_thread_message_css_class filter. This is a copy/paste error introduced in r8674.

Change History (4)

#1 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

While not a regression, it's egregious enough that I suggest we fix it immediately for 2.3.3.

#2 @johnjamesjacoby
4 years ago

In 10058:

Messages: Apply correct filter name in bp_get_the_thread_message_sender_id()

This changeset ensures that the results of bp_get_the_thread_message_sender_id() are not accidentally filtered by bp_get_the_thread_message_css_class.

his bug was introduced in r8674.

See #6599. For 2.3.3 (2.3 branch)

#3 @johnjamesjacoby
4 years ago

In 10059:

Messages: Apply correct filter name in bp_get_the_thread_message_sender_id().

This changeset ensures that the results of bp_get_the_thread_message_sender_id() are not accidentally filtered by bp_get_the_thread_message_css_class.

his bug was introduced in r8674.

See #6599. For 2.4 (trunk)

#4 @johnjamesjacoby
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.