Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6598 closed defect (bug) (fixed)

bp_get_message_thread_subject is double stripslashed

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.3.3 Priority: normal
Severity: normal Version: 1.5
Component: Messages Keywords:
Cc:

Description

In reviewing bp-messages-themes.php I noticed that the output of bp_get_message_thread_subject() is ran through stripslashes_deep before being filtered, and also has bp_get_message_thread_subject() hooked into the filter.

Change History (4)

#1 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned
  • Summary changed from bp_get_message_thread_subject is double strislashed to bp_get_message_thread_subject is double stripslashed

#2 @johnjamesjacoby
4 years ago

In 10056:

Messages: Remove duplicate stripslashes_deep() call in bp_get_message_thread_subject(). The output of bp_get_message_thread_subject() is already filtered by stripslashes_deep().

This changeset fixes the potential for malformed output to occur if slashes are used in the private message thread subject.

See #6598. For 2.4 (trunk)

#3 @johnjamesjacoby
4 years ago

In 10057:

Messages: Remove duplicate stripslashes_deep() call in bp_get_message_thread_subject(). The output of bp_get_message_thread_subject() is already filtered by stripslashes_deep().

This changeset fixes the potential for malformed output to occur if slashes are used in the private message thread subject.

See #6598. For 2.3.3 (2.3 branch)

#4 @johnjamesjacoby
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.