Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#6558 closed defect (bug) (fixed)

Global javascript variables incorrectly defined

Reported by: johnjamesjacoby Owned by: johnjamesjacoby
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.3.0
Component: Core Keywords: 2nd-opinion
Cc:

Description (last modified by johnjamesjacoby)

There are a few places where global variables in javascript files are incorrectly defined, causing issues in my IDE with code completion, scanning, etc...

Some files use:

/* globals foo, boo, etc */

This should be...

/* global foo, boo, etc */

Attachments (1)

6558.1.patch (1.0 KB) - added by johnjamesjacoby 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @johnjamesjacoby
4 years ago

  • Description modified (diff)

#2 @johnjamesjacoby
4 years ago

The WordPress Customizer appears to use globals also, though there are 60ish references of global in other files.

#4 @johnjamesjacoby
4 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 10017:

Scripts: prefer global over globals in a few .js headers. Fixes #6558.

#5 @DJPaul
3 years ago

  • Component changed from Tools - Code Improvement to Core
Note: See TracTickets for help on using tickets.