Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#6541 closed enhancement (fixed)

Use grunt-banner to replace deprecated banners in cssmin and update grunt-conrib-cssmin

Reported by: netweb Owned by: djpaul
Milestone: 2.6 Priority: normal
Severity: major Version: 2.3.0
Component: Build/Test Tools Keywords: needs-patch
Cc:

Description

Support for banners in grunt-contrib-cssmin was removed in v0.11.0

See https://github.com/gruntjs/grunt-contrib-cssmin/commit/985b3d8cb60dd45ff9eaa472662ebea69d3b5eb0

Proposal via WP upstream in #WP30666 is to add banners via grunt-banner

As part of this grunt-contrib-cssmin should also be updated:

"grunt-contrib-cssmin" can be updated from ~0.11.0 to ~0.12.3 (Installed: 0.11.0, Latest: 0.12.3)

Change History (10)

#1 @DJPaul
5 years ago

  • Milestone changed from 2.4 to 2.5

There's movement upstream, let's piggyback on it during 2.5.

#2 @DJPaul
5 years ago

  • Milestone changed from 2.5 to 2.6

#3 @DJPaul
4 years ago

  • Keywords good-first-bug added

#4 @DJPaul
4 years ago

  • Keywords good-first-bug removed
  • Milestone changed from 2.6 to Future Release

#5 @DJPaul
4 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


4 years ago

#8 @DJPaul
4 years ago

  • Milestone changed from Future Release to 2.6

#9 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10705:

Build tools: remove banners added to minified CSS and JS files.

Fixes an issue where the minified file would always change because of the compiled date/time even when there were no code changes.
This was causing unneeded changes when merging/updating when using version control external to BuddyPress.

Fixes #6541

Props netweb

#10 @DJPaul
4 years ago

  • Component changed from Tools - Build Process to Build/Test Tools
Note: See TracTickets for help on using tickets.