Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6539 closed defect (bug) (fixed)

Update Grunt dependencies in package.json

Reported by: netweb Owned by: djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version: 2.3.0
Component: Build/Test Tools Keywords: has-patch commit
Cc:

Description

Current packages and upgrade packages available:

"grunt-checktextdomain" can be updated from ~0.1.1 to ~1.0.0 (Installed: 0.1.1, Latest: 1.0.0)
"grunt-contrib-imagemin" can be updated from ~0.9.3 to ~0.9.4 (Installed: 0.9.4, Latest: 0.9.4)
"grunt-contrib-jshint" can be updated from ~0.11.0 to ~0.11.2 (Installed: 0.11.1, Latest: 0.11.2)
"grunt-contrib-uglify" can be updated from ~0.8.0 to ~0.9.1 (Installed: 0.8.1, Latest: 0.9.1)
"grunt-cssjanus" can be updated from ~0.2.3 to ~0.2.4 (Installed: 0.2.4, Latest: 0.2.4)
"grunt-wp-i18n" can be updated from ~0.5.0 to ~0.5.2 (Installed: 0.5.1, Latest: 0.5.2)

I'm currently testing each of the above for WordPress, BuddyPress, and bbPress, if anyone would like to create a patch for these as they are tested feel free to ping me @netweb in the relevant projects Slack channel.

I will update this ticket with related information for each package individually as I go.

Related: #WP31700 #bbPress2821

Attachments (2)

6539-uglify.diff (183.7 KB) - added by netweb 5 years ago.
6539.diff (1.1 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (14)

#1 @DJPaul
5 years ago

  • Keywords good-first-bug added

#2 @netweb
5 years ago

Update grunt-contrib-jshint to v0.11.2

Changelog: https://github.com/gruntjs/grunt-contrib-jshint/compare/v0.11.0...v0.11.2

  • 2015-04-16   v0.11.2   Fix default value of the reporter option.
  • 2015-03-20   v0.11.1   fix iojs compat issues other fixes to pathing

Running grunt jshint and related BuddyPress Grunt tasks show no issues with grunt-contrib-jshint.

If someone #wceu was to create a patch or would like a hand to create the patch for grunt-contrib-jshint ping me

@netweb
5 years ago

#3 @netweb
5 years ago

Update grunt-contrib-uglify to v0.9.1

Changelog: https://github.com/gruntjs/grunt-contrib-uglify/compare/v0.8.0...v0.9.1

  • 2015-04-07   v0.9.0   added hook into uglify's mangling functionality
  • 2015-03-30   v0.8.1   lock uglify to 2.4.17 due to breaking changes

Running grunt uglify results in quite a few changes of minified JavaScript in the following files:

  • bp-activity/js/mentions.min.js
  • bp-core/js/avatar.min.js
  • bp-core/js/jquery.atwho.min.js
  • bp-core/js/jquery.caret.min.js
  • bp-core/js/webcam.min.js
  • bp-templates/bp-legacy/js/buddypress.min.js

A full diff file 6539-uglify.diff shows the differences before and after this grunt-contrib-uglify change.

#4 @netweb
5 years ago

Update grunt-wp-i18n to v0.5.2

Changelog: https://github.com/cedaro/grunt-wp-i18n/compare/v0.5.0...v0.5.2

  • 0.5.2 Stopped the PHP script from scanning files in excluded directories when running the makepot task.
  • 0.5.1 Merged upstream changes to provide better support for multiline translators comments.

Running grunt makepot and related BuddyPress Grunt tasks show no issues with grunt-wp-i18n.

#5 @netweb
5 years ago

Update grunt-checktextdomain to v1.0.0

Changelog: https://github.com/stephenharris/grunt-checktextdomain

  • 1.0.0 - Potential breaking change: Grunt now aborts on error (grunt.fail.warn). Thanks to @alexVauch. #4. Added force task to configure this behaviour.

Running grunt checktextdomain and related BuddyPress Grunt tasks show no issues with grunt-checktextdomain.

#6 @netweb
5 years ago

Update grunt-contrib-imagemin to v0.9.4:

Changelog: https://github.com/gruntjs/grunt-contrib-imagemin/compare/v0.9.3...v0.9.4

  • 2015-03-22   v0.9.4   Add support for renaming files

Running grunt imagemin results in no new image optimizations for this patch release of grunt-contrib-imagemin.

@netweb
5 years ago

#7 @netweb
5 years ago

  • Keywords has-patch added; needs-patch good-first-bug removed

Patch 6539.diff:

  • grunt-checktextdomain major version update (Improved task error handing)
  • grunt-contrib-imagemin patch version update
  • grunt-contrib-jshint patch version update
  • grunt-contrib-uglify minor version update (causes some changes to minified JS)
  • grunt-wp-i18n patch version update

#8 @netweb
5 years ago

  • Keywords commit added

That's me faking it until gardening privs arrive ;)

#9 @netweb
5 years ago

  • Keywords commit added

That's me adding commit for reals ;)

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


5 years ago

#11 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10018:

Update NPM Grunt packages to latest versions.

  • grunt-checktextdomain major version update (Improved task error handing)
  • grunt-contrib-imagemin patch version update
  • grunt-contrib-jshint patch version update
  • grunt-contrib-uglify minor version update (causes some changes to minified JS)
  • grunt-wp-i18n patch version update

Fixes #6539, props netweb

#12 @DJPaul
4 years ago

  • Component changed from Tools - Build Process to Build/Test Tools
Note: See TracTickets for help on using tickets.