Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6538 closed enhancement (fixed)

Update scsslint.yml

Reported by: hnla Owned by: hnla
Milestone: 2.4 Priority: low
Severity: minor Version:
Component: Core Keywords:
Cc:

Description

BP has used a number of underscore separated tokens over time, sadly this is against convention and the scss linter defaults to selectortype: hyphenated_lowercase

Although we can avoid the use of these few token strings when they arise it can be a nuisance to especially when needing to override BP default styles that have used them.

I have added the Ignored_names line to the lint check block to use for these rare occurrences as we can't change or remove them from core templates safely and added the single use case I have at present.

Change History (2)

#1 @hnla
5 years ago

  • Owner set to hnla
  • Resolution set to fixed
  • Status changed from new to closed

In 9971:

Commit updates scss-lint.ylm to include the ignore_names line for SelectorFormat block.

This is to allow specific existing BP underscored selector name use.

  • Add 'signup_form' id to list

Closes #6538

#2 @DJPaul
4 years ago

  • Component changed from Tools - Code Improvement to Core
Note: See TracTickets for help on using tickets.