Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#6483 closed defect (bug) (fixed)

Deleted messages show up in Starred list

Reported by: sharmstr's profile sharmstr Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.3.2 Priority: normal
Severity: normal Version: 2.3.0
Component: Messages Keywords: has-patch commit
Cc:

Description

If you delete a message that has been starred, it still shows up in your starred list.

Attachments (3)

starred-list.png​ (56.8 KB) - added by sharmstr 9 years ago.
Shows empty inbox, but deleted message still in starred list.
6483.01.patch​ (4.7 KB) - added by r-a-y 9 years ago.
6483.02.patch​ (4.9 KB) - added by imath 9 years ago.

Download all attachments as: .zip

Change History (12)

@sharmstr
9 years ago

Shows empty inbox, but deleted message still in starred list.

#1 @sharmstr
9 years ago

  • Component changed from API to Component - Messaging

@r-a-y
9 years ago

#2 @r-a-y
9 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.3.2
  • Version changed from 2.3.1 to 2.3.0

Confirmed. Thanks for the bug report, sharmstr.

01.patch should fix this. Can you give it a shot?

#3 @sharmstr
9 years ago

Seems to working great. Thank you for the quick fix!

This ticket was mentioned in ​Slack in #buddypress by r-a-y. ​View the logs.
9 years ago

#5 @hnla
9 years ago

Checking issue:
Unpatched deleting a stared message leaves the stared message in stared box
Patched and re-fresh stared box and message is removed. delete another stared message from inbox view and this time it's also removed from stared box.

Patch appears to resolve things nicely.

@imath
9 years ago

#6 @imath
9 years ago

6483.02.patch is 6483.01.patch updated to latest trunk.

Just tested, looks good to me.

#7 @johnjamesjacoby
9 years ago

  • Keywords commit added

Patch looks good to me.

#8 @johnjamesjacoby
9 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 9950:

Messages: Modify message thread queries to exclude messages in deleted threads from "Starred" messages.

This change ensures that deleted messages do not appear in the "Starred" section of a member's private messages. Previously, it was possible to delete a private message thread, and still have it come back to life in the "Starred" messages section.

Fixes #6483. Props r-a-y. (2.3 branch, for 2.3.2)

#9 @johnjamesjacoby
9 years ago

In 9951:

Messages: Modify message thread queries to exclude messages in deleted threads from "Starred" messages.

This change ensures that deleted messages do not appear in the "Starred" section of a member's private messages. Previously, it was possible to delete a private message thread, and still have it come back to life in the "Starred" messages section.

Fixes #6483. Props r-a-y. (trunk, for 2.4.0)

Note: See TracTickets for help on using tickets.