Changeset 9950

Timestamp:

06/16/2015 10:58:07 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Messages: Modify message thread queries to exclude messages in deleted threads from "Starred" messages.

This change ensures that deleted messages do not appear in the "Starred" section of a member's private messages. Previously, it was possible to delete a private message thread, and still have it come back to life in the "Starred" messages section.

Fixes #6483. Props r-a-y. (2.3 branch, for 2.3.2)

Location:

branches/2.3

Files:

• src/bp-messages/bp-messages-star.php (modified) (1 diff)
• src/bp-messages/classes/class-bp-messages-thread.php (modified) (3 diffs)
• tests/phpunit/testcases/messages/star.php (modified) (1 diff)

branches/2.3/src/bp-messages/bp-messages-star.php

@@ -351 +351 @@
  */
 function bp_messages_filter_starred_message_threads( $r = array() ) {
-    $r['user_id'] = 0;
+    $r['box'] = 'starred';
     $r['meta_query'] = array( array(
         'key'   => 'starred_by_user',
-        'value' => bp_loggedin_user_id()
+        'value' => $r['user_id']
     ) );
 

branches/2.3/src/bp-messages/classes/class-bp-messages-thread.php

@@ -456 +456 @@
         $r['user_id'] = (int) $r['user_id'];
 
+        // Default deleted SQL
+        $deleted_sql = 'r.is_deleted = 0';
+
         switch ( $r['box'] ) {
             case 'sentbox' :
@@ -463 +466 @@
 
             case 'inbox' :
-            default :
                 $user_id_sql = 'AND ' . $wpdb->prepare( 'r.user_id = %d', $r['user_id'] );
                 $sender_sql  = 'AND r.sender_only = 0';
+                break;
+
+            // Omit user-deleted threads from all other custom message boxes
+            default :
+                $deleted_sql = $wpdb->prepare( '( r.user_id = %d AND r.is_deleted = 0 )', $r['user_id'] );
                 break;
         }
@@ -484 +491 @@
         $sql['select'] = 'SELECT m.thread_id, MAX(m.date_sent) AS date_sent';
         $sql['from']   = "FROM {$bp->messages->table_name_recipients} r INNER JOIN {$bp->messages->table_name_messages} m ON m.thread_id = r.thread_id {$meta_query_sql['join']}";
-        $sql['where']  = "WHERE r.is_deleted = 0 {$user_id_sql} {$sender_sql} {$type_sql} {$search_sql} {$meta_query_sql['where']}";
+        $sql['where']  = "WHERE {$deleted_sql} {$user_id_sql} {$sender_sql} {$type_sql} {$search_sql} {$meta_query_sql['where']}";
         $sql['misc']   = "GROUP BY m.thread_id ORDER BY date_sent DESC {$pag_sql}";
 

branches/2.3/tests/phpunit/testcases/messages/star.php

@@ -108 +108 @@
 
     /**
+     * @group bp_messages_filter_starred_message_threads
+     */
+    public function test_get_starred_threads_should_not_include_deleted_thread() {
+        $old_current_user = get_current_user_id();
+        $u1 = $this->factory->user->create();
+        $u2 = $this->factory->user->create();
+
+        // create three threads
+        $t1 = $this->factory->message->create( array(
+            'sender_id'  => $u1,
+            'recipients' => array( $u2 ),
+            'subject'    => 'A',
+        ) );
+        $t2 = $this->factory->message->create( array(
+            'sender_id'  => $u1,
+            'recipients' => array( $u2 ),
+            'subject'    => 'B',
+        ) );
+        $t3 = $this->factory->message->create( array(
+            'sender_id'  => $u1,
+            'recipients' => array( $u2 ),
+            'subject'    => 'C',
+        ) );
+
+        // grab the message ids as individual variables
+        list( $m1 ) = $this->get_message_ids( $t1 );
+        list( $m2 ) = $this->get_message_ids( $t2 );
+        list( $m3 ) = $this->get_message_ids( $t3 );
+
+        // star all threads
+        bp_messages_star_set_action( array(
+            'user_id'    => $u2,
+            'message_id' => $m1,
+        ) );
+        bp_messages_star_set_action( array(
+            'user_id'    => $u2,
+            'message_id' => $m2,
+        ) );
+        bp_messages_star_set_action( array(
+            'user_id'    => $u2,
+            'message_id' => $m3,
+        ) );
+
+        // delete the second thread
+        $this->set_current_user( $u2 );
+        messages_delete_thread( $t2 );
+
+        // load the starred threads loop
+        global $messages_template;
+        add_filter( 'bp_after_has_message_threads_parse_args', 'bp_messages_filter_starred_message_threads' );
+        bp_has_message_threads();
+        remove_filter( 'bp_after_has_message_threads_parse_args', 'bp_messages_filter_starred_message_threads' );
+
+        // assert that second thread isn't in starred thread loop
+        $thread_ids = wp_list_pluck( $messages_template->threads, 'thread_id' );
+        $this->assertFalse( in_array( $t2, $thread_ids ) );
+
+        // reset
+        $this->set_current_user( $old_current_user );
+    }
+
+    /**
      * Helper method to grab the message IDs from a message thread.
      *