Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 20 months ago

#6442 closed defect (bug) (fixed)

Undefined function used in bp_group_avatar_edit_form()

Reported by: tw2113 Owned by: djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version: 1.0
Component: Groups Keywords: needs-patch good-first-bug early
Cc:

Description

function bp_group_avatar_edit_form() {
	groups_avatar_upload();
}

No found location of a defined groups_avatar_upload function

Change History (4)

#1 @imath
4 years ago

  • Version set to 1.0

Just did a quick search, bp_group_avatar_edit_form() was used in 1.0 branch in bp-themes/bpmember/groups/admin/group-avatar.php and bp-themes/bpskeletonmember/groups/admin/group-avatar.php

Since 1.1, this function is no more used. I doubt anyone is actually using it anymore because it would generate a fatal error as groups_avatar_upload() doesn't exist. I think we should just remove bp_group_avatar_edit_form().

Last edited 4 years ago by imath (previous) (diff)

#2 @DJPaul
4 years ago

  • Keywords needs-patch good-first-bug early added
  • Milestone changed from Awaiting Review to 2.4

To add to above comments, groups_avatar_upload was removed in the 1.2 release. No-one seems to have reported it missing in the intervening years, and there was a ton of stuff changed between 1.1 and 1.2.

Let's deprecate this function and stick in our backwards compatibility files, as it doesn't cost anything, and who knows - might even fix a fatal error if someone tries to upgrade a 1.1 site. :)

#3 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10255:

Groups: deprecate broken and obsolete functions

These have been broken and unused since BuddyPress 1.2. The commit
formally deprecates them, and restores a missing function
groups_avatar_upload that would cause 1.1-era legacy templates to
fatal on any upgrade.

Fixes #6442

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.


20 months ago

Note: See TracTickets for help on using tickets.