Undefined function used in bp_group_avatar_edit_form()

[tw2113]

function bp_group_avatar_edit_form() {
	groups_avatar_upload();
}

No found location of a defined groups_avatar_upload function

[imath]

Just did a quick search, bp_group_avatar_edit_form() was used in 1.0 branch in bp-themes/bpmember/groups/admin/group-avatar.php and bp-themes/bpskeletonmember/groups/admin/group-avatar.php

Since 1.1, this function is no more used. I doubt anyone is actually using it anymore because it would generate a fatal error as groups_avatar_upload() doesn't exist. I think we should just remove bp_group_avatar_edit_form().

[DJPaul]

To add to above comments, groups_avatar_upload was removed in the 1.2 release. No-one seems to have reported it missing in the intervening years, and there was a ton of stuff changed between 1.1 and 1.2.

Let's deprecate this function and stick in our backwards compatibility files, as it doesn't cost anything, and who knows - might even fix a fatal error if someone tries to upgrade a 1.1 site. :)

[djpaul]

In 10255:

Groups: deprecate broken and obsolete functions

These have been broken and unused since BuddyPress 1.2. The commit
formally deprecates them, and restores a missing function
groups_avatar_upload that would cause 1.1-era legacy templates to
fatal on any upgrade.

Fixes #6442