Skip to:
Content

BuddyPress.org

Opened 10 years ago

Last modified 8 weeks ago

#6441 assigned defect (bug)

Missing break statement inside bp_groups_admin_load() function

Reported by: tw2113's profile tw2113 Owned by: espellcaste's profile espellcaste
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Groups Keywords: needs-patch close
Cc:

Description

The "mod" case section is missing a break statement.

Change History (4)

#1 @imath
10 years ago

If you add the break statement, then it's no more possible to promote a member as a moderator of the group from the administration screen.

So this ticket needs a deeper investigation, we shouldn't touch anything about it in 2.3.

#2 @DJPaul
10 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

#3 @sourabh.matolia
2 months ago

  • Keywords close added

Hello,

Looks like It is intentional that we don't have a 'break' statement under
function 'bp_groups_admin_load' > switch ( $new_role ) > case 'mod'.

case 'mod' > Simply change the user role to 'member', next it gets into the case 'admin'

case 'admin' > Updates the new role to mod (Moderator)

I think we can close the ticket.

#4 @espellcaste
8 weeks ago

  • Milestone changed from Awaiting Contributions to Awaiting Review
  • Owner set to espellcaste
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.